Re: terminate-on-error patch

Mark Kettenis
2005-08-22T19:38:45Z

> Date: Mon, 22 Aug 2005 11:31:24 -0700
> From: Michael Snyder <msnyder@redhat.com>
>
> Sean,
>
> I think this is a great idea, and it seems like a good implementation.
> Kudos on including both documentation and tests!
>
> Anybody see any objection to this going in?

Apart from a line that seems to be too long:

> > Index: gdb/wrapper.h
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/wrapper.h,v
> > retrieving revision 1.14
> > diff -c -r1.14 wrapper.h
> > *** gdb/wrapper.h 16 Feb 2005 13:21:48 -0000 1.14
> > --- gdb/wrapper.h 11 Aug 2005 19:42:17 -0000
> > ***************
> > *** 50,53 ****
> > --- 50,56 ----
> >
> > extern int gdb_parse_and_eval_type (char *, int, struct type **);
> >
> > + /* Longjmp-safe wrapper for "execute_command". */
> > + extern struct gdb_exception safe_execute_command (struct ui_out *,
> > char *, int);

this looks fine to me.

Mark