From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4117 invoked by alias); 22 Aug 2005 19:56:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3704 invoked by uid 22791); 22 Aug 2005 19:55:49 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 22 Aug 2005 19:55:49 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j7MJtcFt006627; Mon, 22 Aug 2005 21:55:38 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j7MJtcM5008118; Mon, 22 Aug 2005 21:55:38 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j7MJtcP0019867; Mon, 22 Aug 2005 21:55:38 +0200 (CEST) Date: Mon, 22 Aug 2005 20:28:00 -0000 Message-Id: <200508221955.j7MJtcP0019867@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: dgm69@us.ibm.com CC: gdb-patches@sources.redhat.com In-reply-to: (message from Dwayne Grant McConnell on Mon, 22 Aug 2005 14:00:11 -0500 (Central Daylight Time)) Subject: Re: [PATCH] Have gdb display float infinity. References: X-SW-Source: 2005-08/txt/msg00234.txt.bz2 > Date: Mon, 22 Aug 2005 14:00:11 -0500 (Central Daylight Time) > From: Dwayne Grant McConnell > > I noticed that gdb does display NaNs in a special way but not infinity. > This patch changes that. I'm a bit new here so I have a few questions. Thanks! Since you're new, I'll have to ask whether you have a copyright assignment for gdb? > 1. Should I submit a testcase to go along with the patch? as a separate > patch? (I have no idea were to put it yet but I figured I would ask.) Yes please! A seperate patch is fine, but make sure it gets in shortly before or after the fix gets in. > 2. I simply duplicated floatformat_is_nan() with one minor change to > produce floatformat_is_inf(). I could have done this differently. Should I > have changed float_format_is_nan() to float_format_is_nan_or_inf() and > given the function a parameter for NaN v Inf? Something else? Hmm, this indeeds seems to duplicate a fair amount of code. Having seperate functions for nan and inf is good I think, but do you see a way to avoid code duplication? > I have tested this with both ppc and ppc64 but nothing else. It'd be great if you also could test this on another platform, preferably amd64, i386 or m68k since those have extended double formats. Mark