From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27439 invoked by alias); 21 Aug 2005 15:21:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27246 invoked by uid 22791); 21 Aug 2005 15:21:09 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 21 Aug 2005 15:21:09 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j7LFL4Ye025606; Sun, 21 Aug 2005 17:21:04 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j7LFL3NB023425; Sun, 21 Aug 2005 17:21:03 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j7LFKx77016199; Sun, 21 Aug 2005 17:20:59 +0200 (CEST) Date: Sun, 21 Aug 2005 15:53:00 -0000 Message-Id: <200508211520.j7LFKx77016199@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: uweigand@de.ibm.com CC: manjo@austin.ibm.com, gdb-patches@sources.redhat.com In-reply-to: <200508211328.j7LDSVhH003835@53v30g15.boeblingen.de.ibm.com> (message from Ulrich Weigand on Sun, 21 Aug 2005 15:28:31 +0200 (CEST)) Subject: Re: [RFC/RFA] Target vectors for native Linux targets References: <200508211328.j7LDSVhH003835@53v30g15.boeblingen.de.ibm.com> X-SW-Source: 2005-08/txt/msg00217.txt.bz2 > From: Ulrich Weigand > Date: Sun, 21 Aug 2005 15:28:31 +0200 (CEST) > > Mark Kettenis wrote: > > > Hmm, it would be preferable to have it the other way around, since > > that would make eliminating the nm-linux.h files, but I can see why > > you did it this way. In the end we might just define USE_LINUX_TARGET > > if GDB_NM_FILE isn't defined. So it's not really important. I've > > added some more comments on the patch inline. > > I guess we could make a config/nm-new-linux.h or something -- that > would be a (temporary) new nm file, but would allow to remove the > per-platform Linux nm files as platforms are converted over ... Don't bother. All the cruft in there has to go away eventually. Making it more cruftier in the meantime isn't a problem. > > Indeed. When I did conversions in the past the > > depreceated_xfer_memory always came back to haunt me, so we have to be > > a bit careful. Did you test your patch on another Linux target that > > wasn't converted yet? > > I tested it on s390 *without* the follow-up patch, and that went > fine as well ... Should be. Although it wouldn't hurt if people tested this patch on their favourite Linux system. > > Daniels earlier attempt had linux_target accept a `struct target_ops > > *' as an argument to serve as an alternative for a plain > > inf_ptrace_target(). I thought that was necessary for i386 and sparc > > Linux targets, but I think I've convinced myself that it isn't. > > Since you can always override the target functions afterwards, > I'm not sure why this would be necessary ... I think Daniels earlier patch did things a little bit differently, eliminating the Linux pseudo-LWP layer. That made overriding things afterwards more difficult. All the more reason to go with your patch instead of reviving Daniels old one. Mark