From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9759 invoked by alias); 21 Aug 2005 13:28:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9748 invoked by uid 22791); 21 Aug 2005 13:28:55 -0000 Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 21 Aug 2005 13:28:55 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.12.10/8.12.10) with ESMTP id j7LDSqd7106294 for ; Sun, 21 Aug 2005 13:28:52 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j7LDSqKF188454 for ; Sun, 21 Aug 2005 15:28:52 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11/8.13.3) with ESMTP id j7LDSqkQ020305 for ; Sun, 21 Aug 2005 15:28:52 +0200 Received: from 53v30g15.boeblingen.de.ibm.com (53v30g15.boeblingen.de.ibm.com [9.152.26.155]) by d12av02.megacenter.de.ibm.com (8.12.11/8.12.11) with ESMTP id j7LDSqY2020301; Sun, 21 Aug 2005 15:28:52 +0200 Received: from 53v30g15.boeblingen.de.ibm.com (localhost [127.0.0.1]) by 53v30g15.boeblingen.de.ibm.com (8.12.10/8.12.10) with ESMTP id j7LDSVom003836; Sun, 21 Aug 2005 15:28:31 +0200 Received: (from uweigand@localhost) by 53v30g15.boeblingen.de.ibm.com (8.12.10/8.12.10/Submit) id j7LDSVhH003835; Sun, 21 Aug 2005 15:28:31 +0200 From: Ulrich Weigand Message-Id: <200508211328.j7LDSVhH003835@53v30g15.boeblingen.de.ibm.com> Subject: Re: [RFC/RFA] Target vectors for native Linux targets To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Sun, 21 Aug 2005 15:21:00 -0000 Cc: uweigand@de.ibm.com, manjo@austin.ibm.com, gdb-patches@sources.redhat.com In-Reply-To: <200508202214.j7KMEC94021466@elgar.sibelius.xs4all.nl> from "Mark Kettenis" at Aug 21, 2005 12:14:12 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2005-08/txt/msg00216.txt.bz2 Mark Kettenis wrote: > Hmm, it would be preferable to have it the other way around, since > that would make eliminating the nm-linux.h files, but I can see why > you did it this way. In the end we might just define USE_LINUX_TARGET > if GDB_NM_FILE isn't defined. So it's not really important. I've > added some more comments on the patch inline. I guess we could make a config/nm-new-linux.h or something -- that would be a (temporary) new nm file, but would allow to remove the per-platform Linux nm files as platforms are converted over ... > > To avoid calling child_xfer_memory I had to switch to using xfer_partial > > instead. This change also bubbled up to linux-thread-db.c. (But seeing > > as xfer_memory is deprecated, that's probably a good idea anyway.) > > Indeed. When I did conversions in the past the > depreceated_xfer_memory always came back to haunt me, so we have to be > a bit careful. Did you test your patch on another Linux target that > wasn't converted yet? I tested it on s390 *without* the follow-up patch, and that went fine as well ... > > What do you think of this approach? > > I think this should be committed. However, since Daniel did some work > in this area before, I'd like to give him the opportunity to comment. > Can you keep this patch on the backburner until he's back? Sure. Thanks for your comments! > Daniels earlier attempt had linux_target accept a `struct target_ops > *' as an argument to serve as an alternative for a plain > inf_ptrace_target(). I thought that was necessary for i386 and sparc > Linux targets, but I think I've convinced myself that it isn't. Since you can always override the target functions afterwards, I'm not sure why this would be necessary ... Bye, Ulrich -- Dr. Ulrich Weigand Linux on zSeries Development Ulrich.Weigand@de.ibm.com