From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21552 invoked by alias); 15 Aug 2005 14:52:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21486 invoked by uid 22791); 15 Aug 2005 14:52:26 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 15 Aug 2005 14:52:26 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j7FEqPoF006497; Mon, 15 Aug 2005 10:52:25 -0400 Received: from post-office.corp.redhat.com (post-office.corp.redhat.com [172.16.52.227]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j7FEqPV04431; Mon, 15 Aug 2005 10:52:25 -0400 Received: from greed.delorie.com (dj.cipe.redhat.com [10.0.0.222]) by post-office.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j7FEqOh20008; Mon, 15 Aug 2005 10:52:24 -0400 Received: from greed.delorie.com (greed.delorie.com [127.0.0.1]) by greed.delorie.com (8.13.1/8.13.1) with ESMTP id j7FEqMtt010513; Mon, 15 Aug 2005 10:52:22 -0400 Received: (from dj@localhost) by greed.delorie.com (8.13.1/8.13.1/Submit) id j7FEqHxA010510; Mon, 15 Aug 2005 10:52:17 -0400 Date: Mon, 15 Aug 2005 15:21:00 -0000 Message-Id: <200508151452.j7FEqHxA010510@greed.delorie.com> From: DJ Delorie To: mark.kettenis@xs4all.nl CC: gcc-patches@gnu.org, binutils@sources.redhat.com, gdb-patches@sources.redhat.com In-reply-to: <200508151415.j7FEFGiV026412@elgar.sibelius.xs4all.nl> (message from Mark Kettenis on Mon, 15 Aug 2005 16:15:16 +0200 (CEST)) Subject: Re: [RFA] s/char/void/g in floatformat.[ch] References: <200508151415.j7FEFGiV026412@elgar.sibelius.xs4all.nl> X-SW-Source: 2005-08/txt/msg00176.txt.bz2 > The fact that the floatformat_xxx functions use `char *' for byte > buffers used to store floating-point numbers doesn't help with GCC > 4's `unsigned char' vs. '(signed) char' "madness". GDB now uses > `gdb_byte' instead of '(unsigned) char', but we obviously cannot use > that in libiberty. Therefore I propose we take the easy way out and > use `void *' for the byte buffers. That should remove the need for > nasty casts in all code that uses the floatformat stuff. > > Mark Ok. > P.S. I still think this code should be removed from libiberty/ and > moved back into gdb/. Or does newlib still use it? opcodes uses it for m68k.