From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40552-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 20543 invoked by alias); 12 Aug 2005 20:54:08 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 20501 invoked by uid 22791); 12 Aug 2005 20:54:05 -0000
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 12 Aug 2005 20:54:05 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2])
	by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j7CKs1Hp023661;
	Fri, 12 Aug 2005 22:54:01 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1])
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j7CKs1bC020064;
	Fri, 12 Aug 2005 22:54:01 +0200 (CEST)
Received: (from kettenis@localhost)
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j7CKs1GS018511;
	Fri, 12 Aug 2005 22:54:01 +0200 (CEST)
Date: Fri, 12 Aug 2005 20:57:00 -0000
Message-Id: <200508122054.j7CKs1GS018511@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: kevinb@redhat.com
CC: gdb-patches@sources.redhat.com
In-reply-to: <20050812134946.62ecd892@ironwood.lan> (message from Kevin
	Buettner on Fri, 12 Aug 2005 13:49:46 -0700)
Subject: Re: [RFC] Add support for Morpho ms1 processor
References: <20050603172038.449a41b9@ironwood.lan>
	<20050811165333.7d9d02f8@ironwood.lan>
	<200508121035.j7CAZs6D029649@elgar.sibelius.xs4all.nl> <20050812134946.62ecd892@ironwood.lan>
X-SW-Source: 2005-08/txt/msg00143.txt.bz2

> Date: Fri, 12 Aug 2005 13:49:46 -0700
> From: Kevin Buettner <kevinb@redhat.com>
> 
> > Please consider usin ARRAY_SIZE.  I'd also use gdb_assert() here
> > instead of the excplicit internal_error(), but that's a bit of a
> > personal preference I assume.  Please use invalid instead of illegal.
> 
> I'm okay with gdb_assert().  That allows us to condense the above bit of
> code to just:
> 
>   gdb_assert (regnum >= 0 && regnum < ARRAY_SIZE (register_names));
>   return register_names[regnum];
> 
> The other benefit to using gdb_assert() is that there's one less string
> for the i18n translators to worry about.

;-)

Mark