From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15641 invoked by alias); 5 Aug 2005 17:39:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15631 invoked by uid 22791); 5 Aug 2005 17:39:02 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 05 Aug 2005 17:39:02 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j75HcxQ8029748; Fri, 5 Aug 2005 19:38:59 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j75Hcx7T027154; Fri, 5 Aug 2005 19:38:59 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j75HcxK3009162; Fri, 5 Aug 2005 19:38:59 +0200 (CEST) Date: Fri, 05 Aug 2005 17:39:00 -0000 Message-Id: <200508051738.j75HcxK3009162@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: fnf@specifix.com CC: gdb-patches@sources.redhat.com, fnf@specifix.com In-reply-to: <200508051156.48102.fnf@specifix.com> (message from Fred Fish on Fri, 5 Aug 2005 11:56:47 -0400) Subject: Re: RFA: Make parse_frame_specification static, remove code duplication References: <200508051156.48102.fnf@specifix.com> X-SW-Source: 2005-08/txt/msg00084.txt.bz2 From: Fred Fish Date: Fri, 5 Aug 2005 11:56:47 -0400 This patch turns a global function, that doesn't need to be global, into a static function, and removes a couple of lines of code duplication in stack.c. 2005-08-02 Fred Fish * defs.h (parse_frame_specification): Remove prototype. * stack.c (parse_frame_specification): Add prototype and make function static. (frame_info): Move common code outside if..then..else. Looks good to me. Mark