From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23234 invoked by alias); 4 Aug 2005 22:40:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23209 invoked by uid 22791); 4 Aug 2005 22:40:51 -0000 Received: from eastrmmtao05.cox.net (HELO eastrmmtao05.cox.net) (68.230.240.34) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 04 Aug 2005 22:40:51 +0000 Received: from white ([68.9.64.121]) by eastrmmtao05.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050804224045.KNHY2947.eastrmmtao05.cox.net@white> for ; Thu, 4 Aug 2005 18:40:45 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1E0oOK-0001I4-00 for ; Thu, 04 Aug 2005 18:40:44 -0400 Date: Thu, 04 Aug 2005 22:40:00 -0000 From: Bob Rossi To: gdb-patches@sources.redhat.com Subject: Re: Fully anchor mi_gdb_test expected results. Message-ID: <20050804224044.GB4931@white> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050804025045.GC32108@white> <20050804041121.GB29482@nevyn.them.org> <20050804140937.GB4054@white> <20050804141750.GA11536@nevyn.them.org> <20050804142601.GC4054@white> <20050804143238.GA11996@nevyn.them.org> <20050804203704.GA4472@white> <20050804205747.GA22030@nevyn.them.org> <20050804211834.GD4472@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050804211834.GD4472@white> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-08/txt/msg00076.txt.bz2 On Thu, Aug 04, 2005 at 05:18:34PM -0400, Bob Rossi wrote: > On Thu, Aug 04, 2005 at 04:57:47PM -0400, Daniel Jacobowitz wrote: > > On Thu, Aug 04, 2005 at 04:37:04PM -0400, Bob Rossi wrote: > > > > proc string_to_regexp {str} { > > > > set result $str > > > > regsub -all {[]*+.|()^$\[]} $str {\\&} result > > > > return $result > > > > } > > > > > > This doesn't seem to work for the " character. > > > > > > Here's the input to string_to_regexp, > > > 555-break-insert -t "\"basics.c\":28" > > > > > > Here's the output, > > > 555-break-insert -t "\"basics\.c\":28" > > > > > > Here is what I need to pass the test (which I hand wrote), > > > -break-insert -t \"\\\\\"basics.c\\\\\":28\" > > > > > > It's a little odd. The quote needs to be escaped once, which makes > > > perfect sense to me. The \ char needs to be escaped with 3 back slashes, > > > to make a total of 4. This is a little odd to me. Is that what > > > string_to_regexp does? > > > > > > Any ideas? > > > > Replace this: > > regsub -all {[]*+.|()^$\[]} $str {\\&} result > > with this: > > regsub -all {[]*+.|()^$\[\\]} $str {\\&} result > > > > i.e. add two backslashes before the closing break. Then does it work? > > Ouch, yes it does. Here are my testsuite results. The first one looks like a bug I introduced, and the others look like random thread pass/failures. Is that correct? Thanks, Bob Rossi --- /home/bob/cvs/gdb/original/objdir/gdb/testsuite/gdb.sum 2005-08-04 18:26:56.000000000 -0400 +++ gdb.sum 2005-08-04 18:26:46.000000000 -0400 @@ -5887,7 +5887,7 @@ PASS: gdb.base/sizeof.exp: get valueof "(int) (char) -1" (-1) PASS: gdb.base/sizeof.exp: get valueof "(int) (signed char) -1" (-1) PASS: gdb.base/sizeof.exp: get valueof "(int) (unsigned char) -1" (255) -PASS: gdb.base/sizeof.exp: check valueof "'\\377'" +FAIL: gdb.base/sizeof.exp: check valueof "'\\377'" PASS: gdb.base/sizeof.exp: check valueof "(int) (char) -1" PASS: gdb.base/sizeof.exp: check valueof "(int) (signed char) -1" PASS: gdb.base/sizeof.exp: check valueof "(int) (unsigned char) -1" @@ -10861,8 +10861,8 @@ PASS: gdb.threads/manythreads.exp: stop threads 1 PASS: gdb.threads/manythreads.exp: info threads PASS: gdb.threads/manythreads.exp: second continue -FAIL: gdb.threads/manythreads.exp: stop threads 2 -FAIL: gdb.threads/manythreads.exp: GDB exits after stopping multithreaded program +PASS: gdb.threads/manythreads.exp: stop threads 2 +PASS: gdb.threads/manythreads.exp: GDB exits after stopping multithreaded program Running ../../../src/gdb/testsuite/gdb.threads/print-threads.exp ... PASS: gdb.threads/print-threads.exp: successfully compiled posix threads test case PASS: gdb.threads/print-threads.exp: set print sevenbit-strings @@ -11109,7 +11109,7 @@ PASS: gdb.threads/tls.exp: 4 info address a_thread_local PASS: gdb.threads/tls.exp: 4 info address another_thread_local PASS: gdb.threads/tls.exp: selected thread: 5 -FAIL: gdb.threads/tls.exp: thread 5 up +PASS: gdb.threads/tls.exp: thread 5 up PASS: gdb.threads/tls.exp: 5 thread print me FAIL: gdb.threads/tls.exp: 5 thread local storage FAIL: gdb.threads/tls.exp: 5 another thread local storage @@ -11277,12 +11277,12 @@ === gdb Summary === -# of expected passes 10783 -# of unexpected failures 31 +# of expected passes 10785 +# of unexpected failures 29 # of unexpected successes 1 # of expected failures 41 # of known failures 59 # of untested testcases 6 # of unsupported tests 6 -/home/bob/cvs/gdb/original/objdir/gdb/testsuite/../../gdb/gdb version 6.3.50.20050804-cvs -nx +/home/bob/cvs/gdb/gdbmi_tcl_ext/objdir/gdb/testsuite/../../gdb/gdb version 6.3.50.20050804-cvs -nx