From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11893 invoked by alias); 3 Aug 2005 18:32:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11807 invoked by uid 22791); 3 Aug 2005 18:32:13 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 03 Aug 2005 18:32:13 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1E0O2F-00040e-9B for gdb-patches@sources.redhat.com; Wed, 03 Aug 2005 14:32:11 -0400 Date: Wed, 03 Aug 2005 18:32:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: MI testsuite to use PTY for inferior Message-ID: <20050803183211.GA15118@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> <17131.64575.780190.163527@farnswood.snap.net.nz> <20050730230309.GA22547@white> <20050731012111.GB13808@nevyn.them.org> <20050803020653.GC29999@white> <20050803131900.GA5169@nevyn.them.org> <20050803182157.GA31469@white> <20050803182351.GB31469@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050803182351.GB31469@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-08/txt/msg00057.txt.bz2 On Wed, Aug 03, 2005 at 02:23:51PM -0400, Bob Rossi wrote: > Sorry, I'm a little trigger happy, here's the patch. Patch is OK with formatting corrections. > Index: gdb/testsuite/ChangeLog > + * gdb.mi/mi-basics.exp: Tell mi_gdb_start to use a PTY for inferior. > + (test_setshow_inferior_tty): Add global mi_inferior_tty_name to scope. > + (test_setshow_inferior_tty): Change tests to inferior-tty-set/show. You shouldn't list the function name twice. > + * gdb.mi/mi-console.exp: Tell mi_gdb_start to use a PTY for inferior. > + (47-exec-next): Use mi_gdb_test to get GDB and Inferior output. > + * gdb.mi/mi-syn-frame.exp: Tell mi_gdb_start to use a PTY for > + inferior. > + (403-exec-continue): Use mi_gdb_test to get GDB and Inferior output. > + (406-data-evaluate-expression have_a_very_merry_interrupt()): Ditto. > + (410-data-evaluate-expression bar()): Ditto. > + (408-exec-continue): Use mi_gdb_test to get GDB output. It's fine this way too, but like I think Nick said, you don't need to mark individual tests in the ChangeLog. We haven't been bothering and no one seems to miss it. > @@ -81,13 +84,17 @@ > } > > # > -# start gdb -- start gdb running, default procedure > +# start gdb INFERIOR_PTY -- start gdb running, default procedure Hmm, that doesn't look right. Did you mean this? # mi_gdb_start [INFERIOR_PTY] -- start gdb running, default procedure > + # create the new pty for the inferior process # Create the new PTY for the inferior process. > + # If allowing the inferior to have it's own PTY then assign the inferior > + # it's own terminal device here # If allowing the inferior to have its own PTY then assign the inferior # its own terminal device here. (trailing period, no apostrophe in the possessive "its") > -# mi_gdb_test COMMAND PATTERN MESSAGE -- send a command to gdb; test the result. > +# mi_gdb_test COMMAND PATTERN MESSAGE IPATTERN -- send a command to gdb; > +# test the result. Please say [IPATTERN] to indicate that it's optional. Yes, I realize it didn't do this before when MESSAGE was optional. > + # if the GDB output matched, compare the inferior output # If the GDB output matched, compare the inferior output. -- Daniel Jacobowitz CodeSourcery, LLC