From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 909 invoked by alias); 3 Aug 2005 18:22:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 848 invoked by uid 22791); 3 Aug 2005 18:22:03 -0000 Received: from eastrmmtao05.cox.net (HELO eastrmmtao05.cox.net) (68.230.240.34) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 03 Aug 2005 18:22:03 +0000 Received: from white ([68.9.64.121]) by eastrmmtao05.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050803182156.MZXR2947.eastrmmtao05.cox.net@white>; Wed, 3 Aug 2005 14:21:56 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1E0NsL-0008Dt-00; Wed, 03 Aug 2005 14:21:57 -0400 Date: Wed, 03 Aug 2005 18:22:00 -0000 From: Bob Rossi To: Nick Roberts , gdb-patches@sources.redhat.com Subject: Re: MI testsuite to use PTY for inferior Message-ID: <20050803182157.GA31469@white> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> <17131.64575.780190.163527@farnswood.snap.net.nz> <20050730230309.GA22547@white> <20050731012111.GB13808@nevyn.them.org> <20050803020653.GC29999@white> <20050803131900.GA5169@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050803131900.GA5169@nevyn.them.org> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-08/txt/msg00054.txt.bz2 On Wed, Aug 03, 2005 at 09:19:00AM -0400, Daniel Jacobowitz wrote: > On Tue, Aug 02, 2005 at 10:06:53PM -0400, Bob Rossi wrote: > > On Sat, Jul 30, 2005 at 09:21:11PM -0400, Daniel Jacobowitz wrote: > > > On Sat, Jul 30, 2005 at 07:03:09PM -0400, Bob Rossi wrote: > > > > However, since that's pretty ugly, I'll take your suggestion and always > > > > create and assign inferior_pty a value. Then I'll check it for the value > > > > of "true" before executing any code. > > > > > > I recommend doing something different. Make the argument a flag, i.e. > > > "mi_gdb_start use-tty". Or "no-tty" depending on what you want the > > > default to be. > > > > Here is an updated patch with all the suggestions made so far, except > > for the ChangeLog suggestion Nick made. Nick, thanks for noticing the > > problems with the original patch! > > > > If preferred, I could add the separate-inferior-tty argument to > > mi_gdb_start only in the tests that need that functionality to pass, > > instead of for all the mi-* tests. This would reduce the patch size > > significantly. > > How about mi-basics.exp (for the set tty tests) and mi-console.exp > only? The other files mostly don't care, except for mi-syn-frame.exp, > and somewhere around here I have a patch that deletes the use of > inferior output from that test - it's just not relevant. Hi Daniel, I decided to keep mi-basics.exp simply because it would be complicated for someone to turn on the separate-inferior-pty option, and know how to re-write the tty tests. I kept the mi-console.exp test for obvious reasons. I also kept the mi-syn-frame.exp tests for now. I don't care if the results get deleted in the future, I just need to make sure that the inferior I/O is separated from GDB/MI's I/O so that I can do a syntax check on GDB/MI's I/O only. The last known issue is to discuss if it matters that mi_gdb_test will give 1 PASS if there is no inferior data, 2 PASS's if there is inferior data and it matches, or 1 PASS and 1 FAIL if there is inferior data and it doesn't match. (This assumes that the GDB data matches). Is this OK? I think it is. Thanks, Bob Rossi