From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13370 invoked by alias); 3 Aug 2005 13:19:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13355 invoked by uid 22791); 3 Aug 2005 13:19:02 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 03 Aug 2005 13:19:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1E0J9A-0001NK-Lu; Wed, 03 Aug 2005 09:19:00 -0400 Date: Wed, 03 Aug 2005 13:19:00 -0000 From: Daniel Jacobowitz To: Nick Roberts , gdb-patches@sources.redhat.com Subject: Re: MI testsuite to use PTY for inferior Message-ID: <20050803131900.GA5169@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> <17131.64575.780190.163527@farnswood.snap.net.nz> <20050730230309.GA22547@white> <20050731012111.GB13808@nevyn.them.org> <20050803020653.GC29999@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050803020653.GC29999@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-08/txt/msg00053.txt.bz2 On Tue, Aug 02, 2005 at 10:06:53PM -0400, Bob Rossi wrote: > On Sat, Jul 30, 2005 at 09:21:11PM -0400, Daniel Jacobowitz wrote: > > On Sat, Jul 30, 2005 at 07:03:09PM -0400, Bob Rossi wrote: > > > However, since that's pretty ugly, I'll take your suggestion and always > > > create and assign inferior_pty a value. Then I'll check it for the value > > > of "true" before executing any code. > > > > I recommend doing something different. Make the argument a flag, i.e. > > "mi_gdb_start use-tty". Or "no-tty" depending on what you want the > > default to be. > > Here is an updated patch with all the suggestions made so far, except > for the ChangeLog suggestion Nick made. Nick, thanks for noticing the > problems with the original patch! > > If preferred, I could add the separate-inferior-tty argument to > mi_gdb_start only in the tests that need that functionality to pass, > instead of for all the mi-* tests. This would reduce the patch size > significantly. How about mi-basics.exp (for the set tty tests) and mi-console.exp only? The other files mostly don't care, except for mi-syn-frame.exp, and somewhere around here I have a patch that deletes the use of inferior output from that test - it's just not relevant. -- Daniel Jacobowitz CodeSourcery, LLC