From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23380 invoked by alias); 3 Aug 2005 12:48:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23342 invoked by uid 22791); 3 Aug 2005 12:47:59 -0000 Received: from eastrmmtao05.cox.net (HELO eastrmmtao05.cox.net) (68.230.240.34) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 03 Aug 2005 12:47:59 +0000 Received: from white ([68.9.64.121]) by eastrmmtao05.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050803124752.YLXP2947.eastrmmtao05.cox.net@white>; Wed, 3 Aug 2005 08:47:52 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1E0If3-00084S-00; Wed, 03 Aug 2005 08:47:53 -0400 Date: Wed, 03 Aug 2005 12:48:00 -0000 From: Bob Rossi To: Nick Roberts , gdb-patches@sources.redhat.com, Daniel Jacobowitz Subject: Re: MI testsuite to use PTY for inferior Message-ID: <20050803124753.GA31013@white> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com, Daniel Jacobowitz References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> <17131.64575.780190.163527@farnswood.snap.net.nz> <20050730230309.GA22547@white> <20050731012111.GB13808@nevyn.them.org> <20050803020653.GC29999@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050803020653.GC29999@white> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-08/txt/msg00052.txt.bz2 On Tue, Aug 02, 2005 at 10:06:53PM -0400, Bob Rossi wrote: > On Sat, Jul 30, 2005 at 09:21:11PM -0400, Daniel Jacobowitz wrote: > > On Sat, Jul 30, 2005 at 07:03:09PM -0400, Bob Rossi wrote: > > > However, since that's pretty ugly, I'll take your suggestion and always > > > create and assign inferior_pty a value. Then I'll check it for the value > > > of "true" before executing any code. > > > > I recommend doing something different. Make the argument a flag, i.e. > > "mi_gdb_start use-tty". Or "no-tty" depending on what you want the > > default to be. > > Here is an updated patch with all the suggestions made so far, except > for the ChangeLog suggestion Nick made. Nick, thanks for noticing the > problems with the original patch! > > If preferred, I could add the separate-inferior-tty argument to > mi_gdb_start only in the tests that need that functionality to pass, > instead of for all the mi-* tests. This would reduce the patch size > significantly. BTW, one other small note. If there is inferior data to match, and the user pass's GDB's output and the inferior's output to gdb_mi_test, 2 PASS's will get generated, instead of one. I don't know if this is the desirable way to do this. Bob Rossi