From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4695 invoked by alias); 31 Jul 2005 15:31:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4675 invoked by uid 22791); 31 Jul 2005 15:30:54 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 31 Jul 2005 15:30:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1DzFm8-0007Pd-Ev; Sun, 31 Jul 2005 11:30:52 -0400 Date: Sun, 31 Jul 2005 15:31:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: Nick Roberts Subject: Re: MI testsuite to use PTY for inferior Message-ID: <20050731153051.GA28158@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Nick Roberts References: <17131.5769.342629.658975@farnswood.snap.net.nz> <20050730173855.GA21401@white> <17131.64575.780190.163527@farnswood.snap.net.nz> <20050730230309.GA22547@white> <20050731012111.GB13808@nevyn.them.org> <20050731131653.GC22547@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050731131653.GC22547@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00237.txt.bz2 On Sun, Jul 31, 2005 at 09:16:53AM -0400, Bob Rossi wrote: > On Sat, Jul 30, 2005 at 09:21:11PM -0400, Daniel Jacobowitz wrote: > > On Sat, Jul 30, 2005 at 07:03:09PM -0400, Bob Rossi wrote: > > > However, since that's pretty ugly, I'll take your suggestion and always > > > create and assign inferior_pty a value. Then I'll check it for the value > > > of "true" before executing any code. > > > > I recommend doing something different. Make the argument a flag, i.e. > > "mi_gdb_start use-tty". Or "no-tty" depending on what you want the > > default to be. > > If it would be OK, I'd prefer to just have the TTY work with all MI > tests, not making it optional. I'd like to repost the patch with all of > the problems found already, and with that additional change. Is this OK? > > My theory is that no FE can/should use MI with out separating the inferior > output via a pty. So, it's OK to test GDB under these assumptions. Well, first, let me ask you a question. What is the intended fate of the old mechanism for interleaved output? The new TTY method has at least two limitations: - As far as I know, native Win32 targets can't use PTYs: http://world.std.com/~jmhart/critcom.htm#UNIX%20Pseudoterminal So, they'll probably need something different. - Remote targets that provide output currently aren't redirected onto the PTY; instead they'll appear interleaved, just like before. Also, Andrew pretty specifically asked you to leave the mi2-* tests alone for this change. -- Daniel Jacobowitz CodeSourcery, LLC