From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9459 invoked by alias); 29 Jul 2005 14:12:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9439 invoked by uid 22791); 29 Jul 2005 14:12:26 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 29 Jul 2005 14:12:26 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1DyVb6-0007RZ-HA; Fri, 29 Jul 2005 10:12:24 -0400 Date: Fri, 29 Jul 2005 14:12:00 -0000 From: Daniel Jacobowitz To: "Kaveh R. Ghazi" Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: add format attributes to gdb Message-ID: <20050729141224.GA28517@nevyn.them.org> Mail-Followup-To: "Kaveh R. Ghazi" , gdb-patches@sources.redhat.com References: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00226.txt.bz2 On Wed, Jul 27, 2005 at 11:10:57PM -0400, Kaveh R. Ghazi wrote: > Hi, > > This patch adds format attributes in various places in gdb. I found > these mainly by compiling gdb using a snapshot of gcc-4.1.x with > -Wmissing-format-attribute. (GCC 4.1.x has some improvements that > find more places to add missing format attributes.) > > In adding these attributes, I used gdb's ATTR_FORMAT macro except > where I worked on function pointers, in which case I used libiberty's > ATTRIBUTE_FPTR_PRINTF. (IMHO, gdb's ATTR_FORMAT should go away in > favor of libiberty's versions, but that's another story.) > > I tested this by compiling gdb-6.3.50.20050727 with a recent gcc-4.1.x > snapshot on x86_64-unknown-linux-gnu plus I compiled gdb using > gcc-2.95 on sparc-sun-solaris2.7 (to test that I used > ATTRIBUTE_FPTR_PRINTF vs ATTR_FORMAT in the right places.) > > Note: I found zero format specifier errors! (Adding these attributes > to gdb will help keep it that way.) It's nice to know that we're perfect... :-) Kaveh, my only gripe is that you've stuck these markers at the end of a bunch of lines that were already quite long. You're past eighty columns in a lot of places. Do you think you could fix that? The rest of the patch looks just fine, of course. -- Daniel Jacobowitz CodeSourcery, LLC