From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8432 invoked by alias); 28 Jul 2005 23:05:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8370 invoked by uid 22791); 28 Jul 2005 23:05:27 -0000 Received: from caip.rutgers.edu (HELO caip.rutgers.edu) (128.6.236.10) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 28 Jul 2005 23:05:27 +0000 Received: from caipclassic.rutgers.edu (caipclassic.rutgers.edu [128.6.237.54]) by caip.rutgers.edu (8.13.3+Sun/8.13.3) with ESMTP id j6SN5Hs0010125; Thu, 28 Jul 2005 19:05:18 -0400 (EDT) Received: from caipclassic.rutgers.edu (localhost [127.0.0.1]) by caipclassic.rutgers.edu (8.12.10+Sun/8.12.9) with ESMTP id j6SN5Hkl017746; Thu, 28 Jul 2005 19:05:17 -0400 (EDT) Received: (from ghazi@localhost) by caipclassic.rutgers.edu (8.12.10+Sun/8.12.9/Submit) id j6SN5Hhr017745; Thu, 28 Jul 2005 19:05:17 -0400 (EDT) Date: Thu, 28 Jul 2005 23:05:00 -0000 From: "Kaveh R. Ghazi" Message-Id: <200507282305.j6SN5Hhr017745@caipclassic.rutgers.edu> To: eliz@gnu.org Subject: Re: PATCH: add format attributes to gdb Cc: gdb-patches@sources.redhat.com References: <200507280310.j6S3AvjH011703@caipclassic.rutgers.edu> X-SW-Source: 2005-07/txt/msg00223.txt.bz2 > > 2005-07-27 Kaveh R. Ghazi > > > > * cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add > > ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF. > > * complaints.c (vcomplaint): Likewise. > > * defs.h (xvasprintf, xstrvprintf, verror, vfatal, > > internal_verror, internal_vwarning, vwarning, > > deprecated_query_hook, deprecated_warning_hook, > > deprecated_readline_begin_hook): Likewise. > > Nitpicking: these multi-line entries are not according to the GNU > coding standards (which specify that each line must end with a right > paren). Ok now? 2005-07-27 Kaveh R. Ghazi * cli-out.c (cli_field_fmt, cli_message, out_field_fmt): Add ATTR_FORMAT or ATTRIBUTE_FPTR_PRINTF. * complaints.c (vcomplaint): Likewise. * defs.h (xvasprintf, xstrvprintf, verror, vfatal) (internal_verror, internal_vwarning, vwarning) (deprecated_query_hook, deprecated_warning_hook) (deprecated_readline_begin_hook): Likewise. * disasm.c (fprintf_disasm): Likewise. * exceptions.c (throw_it): Likewise. * exceptions.h (throw_verror, throw_vfatal): Likewise. * mi/mi-interp.c (mi_interp_query_hook): Likewise. * mi/mi-out.c (mi_field_fmt, mi_message): Likewise. * tui/tui-hooks.c (tui_query_hook): Likewise. * tui/tui-out.c (tui_field_fmt, tui_message, out_field_fmt): Likewise. * ui-out.c (default_field_fmt, default_message, uo_field_fmt) (uo_message): Likewise. * ui-out.h (ui_out_field_fmt, ui_out_message, field_fmt_ftype) (message_ftype): Likewise. * utils.c (vfprintf_maybe_filtered, internal_vproblem) (defaulted_query, printchar): Likewise. gdbserver: * server.h (error, fatal, warning): Add ATTR_FORMAT.