From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21167 invoked by alias); 28 Jul 2005 00:21:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21149 invoked by uid 22791); 28 Jul 2005 00:21:01 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 28 Jul 2005 00:21:01 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1Dxw8v-0006YJ-NR; Wed, 27 Jul 2005 20:20:57 -0400 Date: Thu, 28 Jul 2005 00:21:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: PATCH: tests for MI commands Message-ID: <20050728002057.GA25134@nevyn.them.org> Mail-Followup-To: Nick Roberts , Mark Kettenis , gdb-patches@sources.redhat.com References: <17117.55351.716393.763492@farnswood.snap.net.nz> <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> <17127.29797.456624.592127@farnswood.snap.net.nz> <200507272103.j6RL3HYf022581@elgar.sibelius.xs4all.nl> <17128.2540.73355.406922@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17128.2540.73355.406922@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00217.txt.bz2 On Thu, Jul 28, 2005 at 10:25:48AM +1200, Nick Roberts wrote: > > Given the scarce resources for this unpaid work I ask you again to > > consider removing the mi2-*.exp files and just test the current version > > of MI. The reality is that they serve no useful purpose (mi-*.exp tests > > would still pass if GDB was invoked with "-i=mi2") and they require > > effort that could be better spent on other things. > > > > We can discuss this *after* you either: > > a) Fixed the test failures. > > > > b) Backed out your patch. > > I'd like to do a) by removing the mi2-*.exp files ;-). There doesn't seem > much point in making a load of changes if we are going to just remove the > files afterwards. Obviously this is not uncontroversial, so it is not appropriate as a short term solution. > > You promised not to do this again, and yet you did. > > Let's remember that the testsuite is there to prevent regressions in GDB and > not as an end in itself. Presumably the focus should be on having the right > tests in the suite and not just on ensuring that everything passes. I will echo everyone else's comments here - in particular Stan's. Lots of people run the testsuite, either manually during development or in automated test harnesses, and in either case there's someone who has to look into the new failures when they appear. Leaving things broken is a problem. -- Daniel Jacobowitz CodeSourcery, LLC