From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3565 invoked by alias); 27 Jul 2005 21:25:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3547 invoked by uid 22791); 27 Jul 2005 21:25:07 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 27 Jul 2005 21:25:07 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j6RLP1lQ006405; Wed, 27 Jul 2005 23:25:01 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j6RLP1Y7012434; Wed, 27 Jul 2005 23:25:01 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j6RLOuTm014832; Wed, 27 Jul 2005 23:24:56 +0200 (CEST) Date: Wed, 27 Jul 2005 21:25:00 -0000 Message-Id: <200507272124.j6RLOuTm014832@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: nickrob@snap.net.nz CC: drow@false.org, gdb-patches@sources.redhat.com In-reply-to: <17127.29797.456624.592127@farnswood.snap.net.nz> (message from Nick Roberts on Wed, 27 Jul 2005 23:47:49 +1200) Subject: Re: PATCH: tests for MI commands References: <17117.55351.716393.763492@farnswood.snap.net.nz> <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> <17127.29797.456624.592127@farnswood.snap.net.nz> X-SW-Source: 2005-07/txt/msg00211.txt.bz2 From: Nick Roberts Date: Wed, 27 Jul 2005 23:47:49 +1200 Daniel Jacobowitz writes: > ...But it > looks like these failures are related to your change: > > +FAIL: gdb.mi/mi-var-child.exp: listing of children, simple types: names, type and values, complex types: names and types I don't get this failure (this is one file I did test!). The problem is that in var-cmd.c:do_children_tests(), the member struct_declarations.character is uninitialized. So you in the output you get whatever random value was on the stack. In your case this apparently was 0, but in my case it was -44. The proper thing to do is probably change var-cmd.c to properly initialize the member. But my naive attempt at doing this caused a lot of other failures. Since I don't really understand what this mi stuff is doing, can you please look into it? Mark