From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25497 invoked by alias); 25 Jul 2005 22:19:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25455 invoked by uid 22791); 25 Jul 2005 22:19:46 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 25 Jul 2005 22:19:46 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1DxBIW-00056b-Kv; Mon, 25 Jul 2005 18:19:44 -0400 Date: Mon, 25 Jul 2005 22:19:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] Follow forks on HP-UX 10.20 Message-ID: <20050725221944.GA19564@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200507252212.j6PMCS3j015796@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200507252212.j6PMCS3j015796@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00199.txt.bz2 On Tue, Jul 26, 2005 at 12:12:28AM +0200, Mark Kettenis wrote: > Finally, the goal of this excercise. The code is also going to be > used on OpenBSD when I get the necessary kernel stuff committed. It > doesn't do follow-vfork yet. HP-UX 10.20 doesn't really allow you to > do anything with a vforked child until it execs. So follow-vfork > isn't useful until follow-exec is properly implemented. > > Committed, I'm not really sure this is in the right place. Good, you're going to implement the HP/UX ptrace interface on OpenBSD also. But even then it'll be HP/UX and OpenBSD specific. Why can't they inherit from inf-ptrace.c instead of adding ifdefs to this file? Isn't that the point of target inheritance - to avoid having code in the "base classes" which is only useful on a few targets? > P.S. Daniel, I'm going to remove the messages from inf-ttrace.c such > that things behaves the same way on HP-UX 11.xx as they do on HP-UX > 10.20. Sounds good. > @@ -471,6 +588,9 @@ inf_ptrace_target (void) > t->to_files_info = inf_ptrace_files_info; > t->to_kill = inf_ptrace_kill; > t->to_create_inferior = inf_ptrace_create_inferior; > +#ifdef PT_GET_PROCESS_STATE > + t->to_follow_fork = inf_ptrace_follow_fork; > +#endif > t->to_mourn_inferior = inf_ptrace_mourn_inferior; > t->to_thread_alive = inf_ptrace_thread_alive; > t->to_pid_to_str = normal_pid_to_str; This in particular makes me think it's in the wrong place. -- Daniel Jacobowitz CodeSourcery, LLC