From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26102 invoked by alias); 25 Jul 2005 18:00:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25507 invoked by uid 22791); 25 Jul 2005 18:00:44 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 25 Jul 2005 18:00:44 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j6PHx9EN031894; Mon, 25 Jul 2005 19:59:09 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j6PHx8l4019913; Mon, 25 Jul 2005 19:59:08 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j6PHx4M4008405; Mon, 25 Jul 2005 19:59:04 +0200 (CEST) Date: Mon, 25 Jul 2005 18:00:00 -0000 Message-Id: <200507251759.j6PHx4M4008405@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: paul@codesourcery.com, gdb-patches@sources.redhat.com In-reply-to: <20050725150454.GA6329@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 25 Jul 2005 11:04:54 -0400) Subject: Re: [csl-am] missing SIGTRAP References: <200504291518.05038.paul@codesourcery.com> <20050725150454.GA6329@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00192.txt.bz2 Date: Mon, 25 Jul 2005 11:04:54 -0400 From: Daniel Jacobowitz On Fri, Apr 29, 2005 at 03:18:04PM +0100, Paul Brook wrote: > It appears that the builtin simulators use host signal numbers to > communicate with gdb. This causes problems on windows hosts > because SIGTRAP isn't defined. The attached patch provides a > definition for SIGTRAP if the host doesn't have one. This > probably isn't the "right way" to fix this, but it's near enough > for our purposes. > > Applied to csl-arm-20050325-branch. > > Paul > > 2005-04-29 Paul Brook > > * gdb/remote-sim.c (SIGTRAP): Provide default defnition. > * gdb/signals/signals.c (SIGRAP): Ditto. I was going to ignore this patch for mainline, since it indeed isn't the right way. Then I took a look at the simulators and how much of a PAIN it's going to be to migrate them off of host signal numbers. Does anyone object to the inclusion of this patch? The problem here is the fact that the simulator tries to map host events and simulator events to the same thing isn't it? I'm not too concerned with the simulators, but I think someone who does care should really fix this. Meanwhile I don't object to a local hack in gdb/remote-sim.c. However, I *do* object to the change to gdb/signals/signals.c. This is supposed to be a host to target mapping of signals. Making it pretend that the host has SIGTRAP while it doesn't is a truly bad thing to do. Mark