From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3349 invoked by alias); 25 Jul 2005 15:01:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3334 invoked by uid 22791); 25 Jul 2005 15:01:35 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 25 Jul 2005 15:01:35 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1Dx4ST-0001be-FM; Mon, 25 Jul 2005 11:01:33 -0400 Date: Mon, 25 Jul 2005 15:01:00 -0000 From: Daniel Jacobowitz To: Mark Mitchell Cc: Christopher Faylor , gdb-patches@sources.redhat.com Subject: Re: PATCH: MinGW readline -- revised Message-ID: <20050725150132.GA6158@nevyn.them.org> Mail-Followup-To: Mark Mitchell , Christopher Faylor , gdb-patches@sources.redhat.com References: <200507190011.j6J0B1Ma014410@sethra.codesourcery.com> <20050724211016.GA798@nevyn.them.org> <20050725003930.GA31264@trixie.casa.cgf.cx> <20050725004109.GA17682@nevyn.them.org> <20050725145415.GD31264@trixie.casa.cgf.cx> <42E4FD5F.80107@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42E4FD5F.80107@codesourcery.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00185.txt.bz2 On Mon, Jul 25, 2005 at 07:55:27AM -0700, Mark Mitchell wrote: > Christopher Faylor wrote: > >On Sun, Jul 24, 2005 at 08:41:09PM -0400, Daniel Jacobowitz wrote: > > > >>On Sun, Jul 24, 2005 at 08:39:30PM -0400, Christopher Faylor wrote: > >> > >>>+ #ifdef __MINGW32__ > >>>+ /* On Windows, use a special routine to read a single character > >>>+ from the console. (Otherwise, no characters are available > >>>+ until the user hits the return key.) */ > >>>+ if (isatty (fileno (stream))) > >>>+ return getch (); > >>>+ #endif > >> > >>>This doesn't look right. Shouldn't there be an ifdef there? It's a > >>>minor point but it looks like this would potentially produce dead code. > >> > >>I'm not quite sure what you mean - but if you're talking about the code > >>after the return statement, it looks like something's gone wrong with > >>the indendation in this bit. Getch is only for consoles. > > > > > >I forgot that getch was only for consoles. Somewhow I thought it could be > >used for any stdin. Silly me. Windows. > > So, is the patch OK? Yes, the readline and win32-termcap parts are OK. -- Daniel Jacobowitz CodeSourcery, LLC