From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25532 invoked by alias); 24 Jul 2005 21:10:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25487 invoked by uid 22791); 24 Jul 2005 21:10:18 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 24 Jul 2005 21:10:18 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1Dwnjk-0003MB-Ji; Sun, 24 Jul 2005 17:10:16 -0400 Date: Sun, 24 Jul 2005 21:10:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: Christopher Faylor , Mark Mitchell Subject: Re: PATCH: MinGW readline -- revised Message-ID: <20050724211016.GA798@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Christopher Faylor , Mark Mitchell References: <200507190011.j6J0B1Ma014410@sethra.codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200507190011.j6J0B1Ma014410@sethra.codesourcery.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00174.txt.bz2 On Mon, Jul 18, 2005 at 05:11:01PM -0700, Mark Mitchell wrote: > > This patch is the revised GDB-on-MinGW bit. > > There are three subparts: Unfortunately, this is a good example of why unrelated fixes shouldn't be combined... > 1) Minor bit-rot in remote-sim.c and ser-tcp.c on MinGW. In > particular, SIGTRAP is being used unconditionally in the former, > and the MinGW definition of "close" (in terms of "closesocket") > needs to be a function-like macro, so as to avoid confusion in > code like "ops->close = net_close". I'm not sure why you call this "bit-rot". The unconditional use of SIGTRAP has been there since the oldest version of GDB in CVS. Paul posted a patch to provide a default definition of SIGTRAP instead in two places; his patch is more correct than yours, and is on the csl-arm branch. See the simulator sources to understand why you can't just ignore SIGTRAP here; the simulator will be completely broken by this change. Paul's approach is still somewhat incorrect, in that there is no valid excuse for using native signal numbers here. The simulators really need to be fixed, but it would be a Herculean effort. I am inclined to go with Paul's patch for the nonce. Similarly the reference to ops->close is from 2002. > 2) On the GDB side, I've added a win32-termcap.c file that contains > the stub termcap implementation. There seemed to be no consensus > that it belongs in libiberty, so I've submitted it here. I'd > really appreciate being able to check this in; if it's later > decided that it's wanted in libiberty, I'll happily move it. > > 3) On the readline side, I've backported the MinGW changes that will > be in readline 5.1. These look fine; the changes aren't quite the way I'd have liked them, but if they've been taken for readline 5.1, it's important that we minimize divergence. Chris, do these parts look OK to you? -- Daniel Jacobowitz CodeSourcery, LLC