From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [repost] Support DW_AT_count inside DW_TAG_subrange_type
Date: Thu, 14 Jul 2005 14:11:00 -0000 [thread overview]
Message-ID: <20050714134921.GA769@nevyn.them.org> (raw)
In-Reply-To: <200507141240.48545.ghost@cs.msu.su>
On Thu, Jul 14, 2005 at 12:40:48PM +0400, Vladimir Prus wrote:
>
> Hello,
> I've got not reply to the following message, which was posted on 31/05/2005.
> Any change this patch will go in?
Elena has to review dwarf2 reader patches; I've copied her directly.
>
> Original message below:
>
> Hi,
> the DWARF standard says that the DW_TAG_subrage_type tag can contain either
> DW_AT_upper_bound or use DW_AT_count to specify upper bound relatively to
> lower bound. The version 6.3 of gdb, and the current CVS, support only
> DW_TAG_upper_bound.
>
> The attached patch adds support for DW_AT_count.
>
> The changelog entry could be:
> 2005-05-31 Vladimur Prus <ghost@cs.msu.su>
>
> dwarf2read.c (read_subrange_type): If no DW_AT_upper_bound attribute
> is present, try using DW_AT_count
>
>
>
> Comments?
>
> - Volodya
>
> --- dwarf2read.c.orig 2004-10-16 04:41:00.000000000 +0400
> +++ dwarf2read.c 2005-05-31 17:38:57.000000000 +0400
> @@ -4794,6 +4794,17 @@
> else
> high = dwarf2_get_attr_constant_value (attr, 1);
> }
> + else
> + {
> + /* Alternatively, the high boundary can be specified with the
> + DW_AT_count attribute, which must be added to the low value.
> + */
> + attr = dwarf2_attr (die, DW_AT_count, cu);
> + if (attr)
> + {
> + high = dwarf2_get_attr_constant_value(attr, 0) + low - 1;
> + }
> + }
>
> range_type = create_range_type (NULL, base_type, low, high);
>
--
Daniel Jacobowitz
CodeSourcery, LLC
prev parent reply other threads:[~2005-07-14 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-14 8:41 Vladimir Prus
2005-07-14 14:11 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050714134921.GA769@nevyn.them.org \
--to=drow@false.org \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox