From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4755 invoked by alias); 11 Jul 2005 15:52:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4558 invoked by uid 22791); 11 Jul 2005 15:52:14 -0000 Received: from lakermmtao11.cox.net (HELO lakermmtao11.cox.net) (68.230.240.28) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 11 Jul 2005 15:52:14 +0000 Received: from white ([68.9.64.121]) by lakermmtao11.cox.net (InterMail vM.6.01.05.00 201-2131-123-20050610) with ESMTP id <20050711155155.UTMY221.lakermmtao11.cox.net@white>; Mon, 11 Jul 2005 11:51:55 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1Ds0ZX-000056-00; Mon, 11 Jul 2005 11:51:55 -0400 Date: Mon, 11 Jul 2005 15:52:00 -0000 From: Bob Rossi To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: mi tty commands Message-ID: <20050711155155.GA32323@white> Mail-Followup-To: Mark Kettenis , gdb-patches@sources.redhat.com References: <20050601174149.GA17309@white> <20050602221644.GA21263@white> <20050613030732.GE9288@nevyn.them.org> <20050617210811.GA27959@white> <20050617211427.GA15201@nevyn.them.org> <20050618122921.GA30774@white> <20050703184325.GH13811@nevyn.them.org> <20050706145449.GA17788@white> <200507102108.j6AL8C9B031138@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200507102108.j6AL8C9B031138@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-07/txt/msg00094.txt.bz2 On Sun, Jul 10, 2005 at 11:08:12PM +0200, Mark Kettenis wrote: > Date: Wed, 6 Jul 2005 10:54:49 -0400 > From: Bob Rossi > > On Sun, Jul 03, 2005 at 02:43:25PM -0400, Daniel Jacobowitz wrote: > > On Sat, Jun 18, 2005 at 08:29:21AM -0400, Bob Rossi wrote: > > > Index: gdb/ChangeLog > > > + * fork-child.c (fork-inferior): Use accessor function for > > > + inferior_io_terminal. > > > + * infcmd.c (inferior_io_terminal): Make static. > > > + (set_inferior_io_terminal): New function. > > > + (get_inferior_io_terminal): Ditto. > > > + (tty_command): Use accessor function. > > > + (_initialize_infcmd): Add inferior_tty setshow variable. > > > + (_initialize_infcmd): Remove tty command. > > > + (_initialize_infcmd): Add a tty command that is an alias. > > > + * inferior.h (set_inferior_io_terminal): New prototype. > > > + (get_inferior_io_terminal): Ditto. > > > + (new_tty_prefork): Add const qualifier to parameter. > > > + * inflow.c (inferior_thisrun_terminal): Add const qualifier. > > > + (new_tty_prefork): Add const qualifier to parameter. > > > + * nto-procfs (procfs_create_inferior): Use accessor function. > > > + (procfs_create_inferior): Add const qualifier to locals. > > > + * win32-nat.c (child_create_inferior): Ditto. > > > + * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): New function. > > > + (mi_cmd_inferior_tty_set): Ditto. > > > + * mi/mi-cmds.c (mi_cmds): Add inferior-tty-set and inferior-tty-show > > > + * mi/mi-cmds.h (mi_cmd_inferior_tty_set): Add prototype. > > > + (mi_cmd_inferior_tty_show): Ditto. > > > > > > Index: gdb/doc/ChangeLog > > > + * gdb.texinfo (GDB/MI Miscellaneous Commands): Add -inferior-tty-set > > > + and -inferior-tty-show. > > > + (Input/Output): Document "set/show inferior-tty" and tty alias. > > > > > > Index: gdb/testsuite/ChangeLog > > > + * gdb.mi/mi-basics.exp (test_setshow_inferior_tty): Test MI tty > > > + command. > > > > This is almost completely OK now! Two minor fixes: > > Thanks very much! Committed. Now the interesting patches are coming :) > > Bob, please make sure there are no regressions from your patch before > you check things in. I now get: > > FAIL: gdb.base/default.exp: tty > FAIL: gdb.base/help.exp: help tty > > because the output of the tty command changed. In the past we had: > > (gdb) tty > Argument required (terminal name for running target process). > > whereas now we have > > (gdb) tty > Argument required (filename to set it to.). > > I don't really consider this an improvement... Does anyone know why the "tty" command gives the "default" message when I have, /* add the filename of the terminal connected to inferior I/O */ add_setshow_filename_cmd ("inferior-tty", class_run, &inferior_io_terminal, _("\ Set terminal for future runs of program being debugged."), _("\ Show terminal for future runs of program being debugged."), _("\ Usage: set inferior-tty /dev/pts/1"), NULL, NULL, &setlist, &showlist); add_com_alias ("tty", "set inferior-tty", class_alias, 0); I would expect the alias to take on the usage note from the command it points to. Either that, or allow me to explicitly give it a usage note. Any suggestions? Thanks, Bob Rossi