From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9772 invoked by alias); 10 Jul 2005 21:08:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9718 invoked by uid 22791); 10 Jul 2005 21:08:24 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 10 Jul 2005 21:08:24 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j6AL8L1M020003; Sun, 10 Jul 2005 23:08:21 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j6AL8KUl027622; Sun, 10 Jul 2005 23:08:20 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j6AL8C9B031138; Sun, 10 Jul 2005 23:08:12 +0200 (CEST) Date: Sun, 10 Jul 2005 21:08:00 -0000 Message-Id: <200507102108.j6AL8C9B031138@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: bob@brasko.net CC: gdb-patches@sources.redhat.com In-reply-to: <20050706145449.GA17788@white> (message from Bob Rossi on Wed, 6 Jul 2005 10:54:49 -0400) Subject: Re: mi tty commands References: <20050601130653.GA17103@white> <20050601174149.GA17309@white> <20050602221644.GA21263@white> <20050613030732.GE9288@nevyn.them.org> <20050617210811.GA27959@white> <20050617211427.GA15201@nevyn.them.org> <20050618122921.GA30774@white> <20050703184325.GH13811@nevyn.them.org> <20050706145449.GA17788@white> X-SW-Source: 2005-07/txt/msg00092.txt.bz2 Date: Wed, 6 Jul 2005 10:54:49 -0400 From: Bob Rossi On Sun, Jul 03, 2005 at 02:43:25PM -0400, Daniel Jacobowitz wrote: > On Sat, Jun 18, 2005 at 08:29:21AM -0400, Bob Rossi wrote: > > Index: gdb/ChangeLog > > + * fork-child.c (fork-inferior): Use accessor function for > > + inferior_io_terminal. > > + * infcmd.c (inferior_io_terminal): Make static. > > + (set_inferior_io_terminal): New function. > > + (get_inferior_io_terminal): Ditto. > > + (tty_command): Use accessor function. > > + (_initialize_infcmd): Add inferior_tty setshow variable. > > + (_initialize_infcmd): Remove tty command. > > + (_initialize_infcmd): Add a tty command that is an alias. > > + * inferior.h (set_inferior_io_terminal): New prototype. > > + (get_inferior_io_terminal): Ditto. > > + (new_tty_prefork): Add const qualifier to parameter. > > + * inflow.c (inferior_thisrun_terminal): Add const qualifier. > > + (new_tty_prefork): Add const qualifier to parameter. > > + * nto-procfs (procfs_create_inferior): Use accessor function. > > + (procfs_create_inferior): Add const qualifier to locals. > > + * win32-nat.c (child_create_inferior): Ditto. > > + * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): New function. > > + (mi_cmd_inferior_tty_set): Ditto. > > + * mi/mi-cmds.c (mi_cmds): Add inferior-tty-set and inferior-tty-show > > + * mi/mi-cmds.h (mi_cmd_inferior_tty_set): Add prototype. > > + (mi_cmd_inferior_tty_show): Ditto. > > > > Index: gdb/doc/ChangeLog > > + * gdb.texinfo (GDB/MI Miscellaneous Commands): Add -inferior-tty-set > > + and -inferior-tty-show. > > + (Input/Output): Document "set/show inferior-tty" and tty alias. > > > > Index: gdb/testsuite/ChangeLog > > + * gdb.mi/mi-basics.exp (test_setshow_inferior_tty): Test MI tty > > + command. > > This is almost completely OK now! Two minor fixes: Thanks very much! Committed. Now the interesting patches are coming :) Bob, please make sure there are no regressions from your patch before you check things in. I now get: FAIL: gdb.base/default.exp: tty FAIL: gdb.base/help.exp: help tty because the output of the tty command changed. In the past we had: (gdb) tty Argument required (terminal name for running target process). whereas now we have (gdb) tty Argument required (filename to set it to.). I don't really consider this an improvement... Mark