From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [commit] Properly cast sentinels for concat()
Date: Tue, 05 Jul 2005 04:23:00 -0000 [thread overview]
Message-ID: <20050705042256.GA6548@nevyn.them.org> (raw)
In-Reply-To: <u7jg5q3at.fsf@gnu.org>
On Tue, Jul 05, 2005 at 06:34:18AM +0200, Eli Zaretskii wrote:
> > Date: Mon, 4 Jul 2005 18:51:53 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: Mark Kettenis <kettenis@jive.nl>, gdb-patches@sourceware.org
> >
> > You must cast NULL to a pointer type if you use it as the sentinel in a
> > varargs list, in portable code, because 0 is a legal definition of NULL
> > (according to the C standard, which is quite clear on the subject). On
> > an I32 LP64 system, passing 0 to a varargs function may take 32 bits on
> > the stack while passing NULL takes 64 bits.
>
> But in Mark's case, NULL is defined as (void *)0, so it's a pointer,
> not an int.
No, OpenBSD uses 0 rather than (void *) 0. As the language allows.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-07-05 4:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-04 13:36 Mark Kettenis
2005-07-04 22:08 ` Eli Zaretskii
2005-07-04 23:16 ` Andreas Schwab
2005-07-05 1:32 ` Daniel Jacobowitz
2005-07-05 3:34 ` Eli Zaretskii
2005-07-05 4:23 ` Daniel Jacobowitz [this message]
2005-07-05 7:30 ` Mark Kettenis
2005-07-05 20:03 ` Eli Zaretskii
2005-07-05 7:36 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050705042256.GA6548@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox