From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30698 invoked by alias); 4 Jul 2005 03:51:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30622 invoked by uid 22791); 4 Jul 2005 03:51:03 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 04 Jul 2005 03:51:03 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DpHz1-0001nd-TO; Sun, 03 Jul 2005 23:50:59 -0400 Date: Mon, 04 Jul 2005 03:51:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Eli Zaretskii , Bob Rossi , gdb-patches@sources.redhat.com Subject: Re: [PATCH: gdb/mi + doco] -var-update Message-ID: <20050704035059.GB5802@nevyn.them.org> Mail-Followup-To: Nick Roberts , Eli Zaretskii , Bob Rossi , gdb-patches@sources.redhat.com References: <20050401024942.GA2179@white> <17013.35649.62745.226730@farnswood.snap.net.nz> <20050502040526.GA10023@nevyn.them.org> <17013.54662.20554.239976@farnswood.snap.net.nz> <20050617034329.GH17013@nevyn.them.org> <20050617140410.GA24575@nevyn.them.org> <20050703195630.GM13811@nevyn.them.org> <17096.43077.948790.211753@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17096.43077.948790.211753@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00040.txt.bz2 On Mon, Jul 04, 2005 at 03:08:53PM +1200, Nick Roberts wrote: > Daniel Jacobowitz writes: > ... > > Nick, here's a patch based on yours which adds -var-list-children > > --simple-values and -var-update --simple-values/--all-values. I like > > it; I think --simple-values is useful (since for anything other than > > simple values, an IDE is likely to want to print each member > > individually...). > > > > I didn't revise the documentation because your last posted patch didn't > > include the current manual diff. I also didn't write any testcases. > > Both of these need to be done before the patch goes in. Tested on > > i686-pc-linux-gnu, both the testsuite and by hand for -var-update. > > > > No incompatible changes, option consistency, and behavior consistency. > > I don't think I can do any better than this :-) Nick, Eli, are you > > both OK with this version of the code changes? > > Yes, this looks good. I have tested it with my current version of gdb-mi.el > and it seems to work. I will try to dig out the relevant patch for the > documentation and rework it, if Eli is also agreeable to this revision. Thanks! Once we've reached consensus on this, will your current gdb-mi.el be compatible with FSF GDB again? > ... > > - if (argc != 1 && argc != 2) > > + if (argc > 2) > > This gives: > > (gdb) > -var-list-children > &"Variable object not found\n" > ^error,msg="Variable object not found" > (gdb) > > instead of: > > (gdb) > -var-list-children > &"mi_cmd_var_list_children: Usage: NAME.\n" > ^error,msg="mi_cmd_var_list_children: Usage: NAME." > (gdb) > > I don't know if that's what you intended. Blech. That's what I get for trying to be clever. No, the old version was right. I'll correct. -- Daniel Jacobowitz CodeSourcery, LLC