From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2379 invoked by alias); 3 Jul 2005 19:04:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2366 invoked by uid 22791); 3 Jul 2005 19:04:51 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 03 Jul 2005 19:04:51 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1Dp9lp-0008TD-Qc; Sun, 03 Jul 2005 15:04:49 -0400 Date: Sun, 03 Jul 2005 19:04:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Removal of markup annotations Message-ID: <20050703190449.GJ13811@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17071.40307.949193.158796@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17071.40307.949193.158796@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00027.txt.bz2 On Wed, Jun 15, 2005 at 03:16:03PM +1200, Nick Roberts wrote: > > Here's the patch for the removal of some of the level 2 annotations that I > referred to yesterday. It primarily removes the markup annotations that > worked just with level (annotation_level == 2) and leaves those which also > worked with level 3 (annotation_level > 2). But it also restricts > breakpoints_changed and annotate_frames_invalid to level 2. > breakpoints_changed doesn't get called at the moment because currently > deprecated_delete_breakpoint_hook and deprecated_modify_breakpoint_hook have > been set to zero in clear_interpreter_hooks. I have already submitted a > patch for this (2005-06-04). > > This patch cleans up the code quite considerably and hopefully will relieve > some of the pressure to remove the remaining annotations. Is there "pressure"? I don't see the point in snipping out bits of -annotate=2 until we're ready to remove it entirely, which I would like to do but I accept that we are not yet ready for. -- Daniel Jacobowitz CodeSourcery, LLC