From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29826 invoked by alias); 3 Jul 2005 18:43:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29792 invoked by uid 22791); 3 Jul 2005 18:43:26 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 03 Jul 2005 18:43:26 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1Dp9R7-0008Lj-My for gdb-patches@sources.redhat.com; Sun, 03 Jul 2005 14:43:25 -0400 Date: Sun, 03 Jul 2005 18:43:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: mi tty commands Message-ID: <20050703184325.GH13811@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050601001440.GB15414@white> <20050601130653.GA17103@white> <20050601174149.GA17309@white> <20050602221644.GA21263@white> <20050613030732.GE9288@nevyn.them.org> <20050617210811.GA27959@white> <20050617211427.GA15201@nevyn.them.org> <20050618122921.GA30774@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050618122921.GA30774@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00025.txt.bz2 On Sat, Jun 18, 2005 at 08:29:21AM -0400, Bob Rossi wrote: > Index: gdb/ChangeLog > + * fork-child.c (fork-inferior): Use accessor function for > + inferior_io_terminal. > + * infcmd.c (inferior_io_terminal): Make static. > + (set_inferior_io_terminal): New function. > + (get_inferior_io_terminal): Ditto. > + (tty_command): Use accessor function. > + (_initialize_infcmd): Add inferior_tty setshow variable. > + (_initialize_infcmd): Remove tty command. > + (_initialize_infcmd): Add a tty command that is an alias. > + * inferior.h (set_inferior_io_terminal): New prototype. > + (get_inferior_io_terminal): Ditto. > + (new_tty_prefork): Add const qualifier to parameter. > + * inflow.c (inferior_thisrun_terminal): Add const qualifier. > + (new_tty_prefork): Add const qualifier to parameter. > + * nto-procfs (procfs_create_inferior): Use accessor function. > + (procfs_create_inferior): Add const qualifier to locals. > + * win32-nat.c (child_create_inferior): Ditto. > + * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): New function. > + (mi_cmd_inferior_tty_set): Ditto. > + * mi/mi-cmds.c (mi_cmds): Add inferior-tty-set and inferior-tty-show > + * mi/mi-cmds.h (mi_cmd_inferior_tty_set): Add prototype. > + (mi_cmd_inferior_tty_show): Ditto. > > Index: gdb/doc/ChangeLog > + * gdb.texinfo (GDB/MI Miscellaneous Commands): Add -inferior-tty-set > + and -inferior-tty-show. > + (Input/Output): Document "set/show inferior-tty" and tty alias. > > Index: gdb/testsuite/ChangeLog > + * gdb.mi/mi-basics.exp (test_setshow_inferior_tty): Test MI tty > + command. This is almost completely OK now! Two minor fixes: > Index: gdb/mi/mi-cmds.c > =================================================================== > RCS file: /cvs/src/src/gdb/mi/mi-cmds.c,v > retrieving revision 1.16 > diff -w -u -r1.16 mi-cmds.c > --- gdb/mi/mi-cmds.c 11 Feb 2005 18:13:55 -0000 1.16 > +++ gdb/mi/mi-cmds.c 18 Jun 2005 12:21:32 -0000 > @@ -153,6 +153,8 @@ > { "trace-save", { NULL, 0 }, NULL, NULL }, > { "trace-start", { NULL, 0 }, NULL, NULL }, > { "trace-stop", { NULL, 0 }, NULL, NULL }, > + { "inferior-tty-set", { NULL, 0 }, NULL, mi_cmd_inferior_tty_set}, > + { "inferior-tty-show", { NULL, 0 }, NULL, mi_cmd_inferior_tty_show}, > { "var-assign", { NULL, 0 }, 0, mi_cmd_var_assign}, > { "var-create", { NULL, 0 }, 0, mi_cmd_var_create}, > { "var-delete", { NULL, 0 }, 0, mi_cmd_var_delete}, > Index: gdb/mi/mi-cmds.h > =================================================================== > RCS file: /cvs/src/src/gdb/mi/mi-cmds.h,v > retrieving revision 1.15 > diff -w -u -r1.15 mi-cmds.h > --- gdb/mi/mi-cmds.h 13 Jan 2005 22:08:27 -0000 1.15 > +++ gdb/mi/mi-cmds.h 18 Jun 2005 12:21:32 -0000 > @@ -96,6 +96,8 @@ > extern mi_cmd_args_ftype mi_cmd_target_select; > extern mi_cmd_argv_ftype mi_cmd_thread_list_ids; > extern mi_cmd_argv_ftype mi_cmd_thread_select; > +extern mi_cmd_argv_ftype mi_cmd_inferior_tty_set; > +extern mi_cmd_argv_ftype mi_cmd_inferior_tty_show; > extern mi_cmd_argv_ftype mi_cmd_var_assign; > extern mi_cmd_argv_ftype mi_cmd_var_create; > extern mi_cmd_argv_ftype mi_cmd_var_delete; At some point the commant must have been named -tty-set, because then these lists would be nicely alphabetized :-) Please put these in the right place. > Index: gdb/testsuite/gdb.mi/mi-basics.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v > retrieving revision 1.9 > diff -w -u -r1.9 mi-basics.exp > --- gdb/testsuite/gdb.mi/mi-basics.exp 9 Aug 2004 16:32:44 -0000 1.9 > +++ gdb/testsuite/gdb.mi/mi-basics.exp 18 Jun 2005 12:21:40 -0000 Missing a copyright year update. Feel free to check it in with those changes. -- Daniel Jacobowitz CodeSourcery, LLC