[PATCH] Hooks still needed for annotations

Nick Roberts
2005-06-01T07:15:36Z

On 2004-04-21 the lines below were added to clear_interpreter_hooks in
interps.c:

deprecated_delete_breakpoint_hook = 0;
deprecated_modify_breakpoint_hook = 0;

Previously they were set to breakpoint_changed (a more natural name would be
annotate_breakpoints_invalid). This means that sometimes breakpoints-invalid
annotations aren't generated. In particular this is the case when a breakpoint
is toggled between its enabled state and disabled state.

Although the intention is to eventually remove annotations I don't think this
stage has been reached yet and it makes little sense to remove a small
number of calls. The patch below re-instates them.

Nick

2005-06-01 Nick Roberts <nickrob@snap.net.nz>

* interps.c (clear_interpreter_hooks):
Re-instate deprecated_delete_breakpoint_hook and
deprecated_modify_breakpoint_hook for annotations.

*** /home/nick/src/gdb/interps.c.~1.15.~ 2005-04-26 21:44:15.000000000 +1200
--- /home/nick/src/gdb/interps.c 2005-06-01 19:10:35.000000000 +1200
***************
*** 326,333 ****
deprecated_query_hook = 0;
deprecated_warning_hook = 0;
deprecated_create_breakpoint_hook = 0;
! deprecated_delete_breakpoint_hook = 0;
! deprecated_modify_breakpoint_hook = 0;
deprecated_interactive_hook = 0;
deprecated_registers_changed_hook = 0;
deprecated_readline_begin_hook = 0;
--- 326,334 ----
deprecated_query_hook = 0;
deprecated_warning_hook = 0;
deprecated_create_breakpoint_hook = 0;
! /* These hooks are needed for annotations
! deprecated_delete_breakpoint_hook = 0;
! deprecated_modify_breakpoint_hook = 0; */
deprecated_interactive_hook = 0;
deprecated_registers_changed_hook = 0;
deprecated_readline_begin_hook = 0;