Re: [PATCH] Hooks still needed for annotations

Nick Roberts
2005-07-03T22:13:24Z

> Having reread the discussion I would like to ask you what your goal is
> with this patch. You don't use this annotation, and you've said that
> it is very awkward to use because of the amount of output it produces.
> Why should we fix it (as opposed to garbage collecting it) if no one
> has missed it?

The original authors must have seen a need when they created these
annotations. I was just being conservative because there hasn't been a
release of Emacs to test my code fully.

> The comments in mention() suggest that at one time, GDB was trying to
> move away from breakpoints_changed to a more specific set of hooks.
> But now the hooks are more or less dead, and to get full mileage out of
> them they're going to need a redesign. So maybe we should just delete
> all three hooks, and replace the two that annotations use with
> calls to breakpoints_changed.

Yes that looks a lot simpler. If you are agreeable to me fixing it in the
first place, I will do that.

Nick