Re: [PATCH] Hooks still needed for annotations

Bob Rossi
2005-06-01T11:30:27Z

On Wed, Jun 01, 2005 at 07:15:45PM +1200, Nick Roberts wrote:
>
> On 2004-04-21 the lines below were added to clear_interpreter_hooks in
> interps.c:
>
> deprecated_delete_breakpoint_hook = 0;
> deprecated_modify_breakpoint_hook = 0;
>
> Previously they were set to breakpoint_changed (a more natural name would be
> annotate_breakpoints_invalid). This means that sometimes breakpoints-invalid
> annotations aren't generated. In particular this is the case when a breakpoint
> is toggled between its enabled state and disabled state.
>
> Although the intention is to eventually remove annotations I don't think this
> stage has been reached yet and it makes little sense to remove a small
> number of calls. The patch below re-instates them.

Nick, in order for you to guarentee that your Emacs is working properly,
you are going to have to update the breakpoints after every command the
user types. Even though I think adding the patch is a good idea, if you
don't update the breakpoints after every command, bugs like this will
make it so that some users do not get the updated breakpoints.

For instance, make a small main program, add a breakpoint, and then
immediatly delete it. I doubt you will get the breakpoints-invalid
annotation. The problem is, even if you fix them, you still have to
check the breakpoints after every command unless you query GDB for it's
version number to see if the bug is fixed.

Bob Rossi