From: Martin Simmons <qqxnjvamvxwx@spammotel.com>
To: gdb-patches@sources.redhat.com
Subject: Patch to prevent tilde crashing readline
Date: Sat, 02 Jul 2005 22:49:00 -0000 [thread overview]
Message-ID: <20050702224856.037DC1D14D@cpc4-cmbg1-6-0-cust148.cmbg.cable.ntl.com> (raw)
Here is a patch to the gdb readline to fix a typo in the MinGW changes. The
current CVS gdb segfaults on x86_64 FC3 Linux whenever ~ is used, e.g.
source ~martin/my-commands
The segfault is in strlen(), called from tilde_expand(), because
tilde_expand_word() returns NULL when HAVE_GETPWNAM is not defined
(i.e. always!). Someone should fix tilde_expand_word() to do the existing
else clause in this case.
Please CC me on any replies as I am not subscribed.
--
Martin Simmons
Index: readline/configure
===================================================================
RCS file: /cvs/src/src/readline/configure,v
retrieving revision 1.10
diff -u -r1.10 configure
--- readline/configure 9 May 2005 19:42:02 -0000 1.10
+++ readline/configure 29 Jun 2005 11:56:07 -0000
@@ -4139,7 +4139,7 @@
for ac_func in fcntl kill lstat memmove putenv select setenv setlocale \
strcasecmp strpbrk tcgetattr vsnprintf isascii isxdigit \
- getpwname getpwent getpwuid
+ getpwnam getpwent getpwuid
do
as_ac_var=`echo "ac_cv_func_$ac_func" | $as_tr_sh`
echo "$as_me:$LINENO: checking for $ac_func" >&5
Index: readline/configure.in
===================================================================
RCS file: /cvs/src/src/readline/configure.in,v
retrieving revision 1.7
diff -u -r1.7 configure.in
--- readline/configure.in 9 May 2005 19:42:03 -0000 1.7
+++ readline/configure.in 29 Jun 2005 11:56:07 -0000
@@ -120,7 +120,7 @@
AC_CHECK_FUNCS(fcntl kill lstat memmove putenv select setenv setlocale \
strcasecmp strpbrk tcgetattr vsnprintf isascii isxdigit \
- getpwname getpwent getpwuid)
+ getpwnam getpwent getpwuid)
AC_FUNC_STRCOLL
next reply other threads:[~2005-07-02 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-02 22:49 Martin Simmons [this message]
2005-07-03 8:23 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050702224856.037DC1D14D@cpc4-cmbg1-6-0-cust148.cmbg.cable.ntl.com \
--to=qqxnjvamvxwx@spammotel.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox