From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30784 invoked by alias); 30 Jun 2005 02:53:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29458 invoked by uid 22791); 30 Jun 2005 02:53:25 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 30 Jun 2005 02:53:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DnpB5-0006ta-Jj; Wed, 29 Jun 2005 22:53:23 -0400 Date: Thu, 30 Jun 2005 02:53:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Start Fortran support for variable objects. Message-ID: <20050630025323.GA26397@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17091.4780.953681.620094@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17091.4780.953681.620094@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00385.txt.bz2 On Thu, Jun 30, 2005 at 09:29:16AM +1200, Nick Roberts wrote: > > This patch adjusts the offset from 0 to 1 to allow the display of arrays > in Fortran using variable objects. I see that you're hardcoding this based on language. Can we do it based on type instead? Specifically, TYPE_LOW_BOUND and TYPE_HIGH_BOUND. We have got type information here - unless I'm misreading, var->type should be the type of the array. I'm not thrilled with the existing language-dependent behavior in varobj; we have got a common type system, after all. -- Daniel Jacobowitz CodeSourcery, LLC