From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40143-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 27436 invoked by alias); 28 Jun 2005 21:08:49 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 27424 invoked by uid 22791); 28 Jun 2005 21:08:47 -0000
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 28 Jun 2005 21:08:47 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2])
	by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j5SL8VYF003825;
	Tue, 28 Jun 2005 23:08:32 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1])
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j5SL8VxD003188;
	Tue, 28 Jun 2005 23:08:31 +0200 (CEST)
Received: (from kettenis@localhost)
	by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j5SL8QhZ029007;
	Tue, 28 Jun 2005 23:08:26 +0200 (CEST)
Date: Tue, 28 Jun 2005 21:08:00 -0000
Message-Id: <200506282108.j5SL8QhZ029007@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@redhat.com
CC: gdb-patches@sources.redhat.com, drow@false.org
In-reply-to: <42C09C74.1010507@redhat.com> (message from Michael Snyder on
	Mon, 27 Jun 2005 17:40:20 -0700)
Subject: Re: [RFA]  Take III, part 2: am33 linux corefile support
References:  <42C09C74.1010507@redhat.com>
X-SW-Source: 2005-06/txt/msg00376.txt.bz2

   Date: Mon, 27 Jun 2005 17:40:20 -0700
   From: Michael Snyder <msnyder@redhat.com>

   OK, here's this part again.  Mark, I used the osabi mechanism
   to register my corefile handlers, and I changed the typedefs
   from unsigned char to gdb_byte.

Great!  But I have the same question as Daniel regarding the need for
the sniffer.  Please make am33_regset_from_core_section static and
remove the prototype from mn10300-tdep.h.  That removes the need to
include "regset.h" there[1].  Oh, and please remove the needless (void
*) cast in the register_raw_supply and register_raw_collect calls.

Be advised that there are Linux systems out there that leak things in
the ELF_ and elf_ "namespaces".  This code won't compile on those
systems.

Mark

[1] Which shouldn't have been done in the first place; a forward
    "struct regset" declaration would have been enough.