From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14584 invoked by alias); 23 Jun 2005 20:11:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14530 invoked by uid 22791); 23 Jun 2005 20:11:12 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 23 Jun 2005 20:11:12 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j5NKAd4U029229; Thu, 23 Jun 2005 22:10:39 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j5NKAdtQ030051; Thu, 23 Jun 2005 22:10:39 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j5NKAcNi006431; Thu, 23 Jun 2005 22:10:38 +0200 (CEST) Date: Thu, 23 Jun 2005 20:11:00 -0000 Message-Id: <200506232010.j5NKAcNi006431@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: schwab@suse.de CC: harrington.chad@gmail.com, gdb-patches@sources.redhat.com In-reply-to: (message from Andreas Schwab on Thu, 23 Jun 2005 11:21:54 +0200) Subject: Re: typo in gdb/gdb_ptrace.c References: X-SW-Source: 2005-06/txt/msg00359.txt.bz2 From: Andreas Schwab Cc: gdb-patches@sources.redhat.com Chad Harrington writes: > Below is the diff patch for my fix. It is not critical, but it sure > looks like a mistake to me. This was in gdb-6.3, as you can see. The > preprocessor is told to define PT_ATTACH if PTRACE_DETACH is defined. > I think it should only define PT_ATTACH if PTRACE_ATTACH is defined, > but I think they'd both be defined if one or the other is already > defined anyway... It merely appears to be a typo. :-) There is another typo in the previous line. I've checked this in as obvious. 2005-06-23 Andreas Schwab * gdb_ptrace.h: Fix typos when checking for PT_ATTACH. Reported by Chad Harrington . Thanks! Mark