From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40122-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 26777 invoked by alias); 23 Jun 2005 03:48:20 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26657 invoked by uid 22791); 23 Jun 2005 03:48:14 -0000
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 23 Jun 2005 03:48:14 +0000
Received: from drow by nevyn.them.org with local (Exim 4.51)
	id 1DlIhE-0001Tk-9Q; Wed, 22 Jun 2005 23:48:08 -0400
Date: Thu, 23 Jun 2005 03:48:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Jason Molenda <jmolenda@apple.com>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI error messages
Message-ID: <20050623034808.GA5493@nevyn.them.org>
Mail-Followup-To: Nick Roberts <nickrob@snap.net.nz>,
	Jason Molenda <jmolenda@apple.com>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sources.redhat.com
References: <17078.19977.660644.9978@farnswood.snap.net.nz> <20050620135108.GA29453@nevyn.them.org> <17079.14386.484824.134375@farnswood.snap.net.nz> <uekawz5j8.fsf@gnu.org> <17079.57494.321274.96102@farnswood.snap.net.nz> <u8y13zb5u.fsf@gnu.org> <17080.35377.519988.619664@farnswood.snap.net.nz> <4B2E0CF3-987A-41E8-A2B3-0ADD6955DAF7@apple.com> <20050622033214.GA22609@nevyn.them.org> <17081.4881.865930.852121@farnswood.snap.net.nz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17081.4881.865930.852121@farnswood.snap.net.nz>
User-Agent: Mutt/1.5.8i
X-SW-Source: 2005-06/txt/msg00355.txt.bz2

On Wed, Jun 22, 2005 at 07:28:17PM +1200, Nick Roberts wrote:
>  > We have a syntax for error messages... let's use it?
> 
> Are you referring to the return value MI_CMD_ERROR?  Interestingly this isn't
> used at all in mi-cmd-var.c or mi-cmd-stack.c but I think it is more
> appropriate for the errors generated there.  It only goes back to
> captured_mi_execute_command and doesn't generate any output in the log stream
> (&"...").  I'm not too keen on procedures with lots of return points though.

I'm referring to the syntax, which is ^error.  If returning
MI_CMD_ERROR works, then that way is fine.

I don't get your objection.  error() is a return point anyway.

-- 
Daniel Jacobowitz
CodeSourcery, LLC