From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21083 invoked by alias); 20 Jun 2005 03:00:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21057 invoked by uid 22791); 20 Jun 2005 03:00:11 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 03:00:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DkCWA-0007Mv-8u; Sun, 19 Jun 2005 23:00:10 -0400 Date: Mon, 20 Jun 2005 03:00:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] mi-stack.exp Message-ID: <20050620030010.GA28107@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17078.5246.665299.878084@farnswood.snap.net.nz> <20050620013409.GB30942@nevyn.them.org> <17078.10651.458286.19457@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17078.10651.458286.19457@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00308.txt.bz2 On Mon, Jun 20, 2005 at 02:27:39PM +1200, Nick Roberts wrote: > > OK. Please wrap it this way: > > > > * gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for > > -stack-select-frame without arguments. > > (test_stack_frame_listing): Add test for newly implemented command > > -stack-info-frame. > > OK. (I find the log message easier to read when it fits on one line) Yeah, it is kinda - but this is the way all the others look, more consistently. > > > *** /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp.~1.15.~ 2005-05-18 > > > 20:18:15.000000000 +1200 --- > > > /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp 2005-06-19 > > > 18:49:18.000000000 +1200 > > > > Could you see about submitting relative diffs? It doesn't really > > matter what they're relative _to_ - common is -p0 or -p1 to the top > > directory whose ChangeLog you're touching. But this is a bit awkward > > to apply. > > Like below? (This is with vc-diff in Emacs) Ideally, something like "testsuite/gdb.mi/mi-stack.exp"; the result of "cvs diff" from within the gdb/ directory. Or for things outside of gdb, within the top level directory. The goal is to provide something that can easily be applied. To apply the above, I need to work out that /home/nick/src/gdb is -p4. But if it just said testsuite/, I'd know immediately that it was -p0 from the gdb directory. With just "mi-stack.exp" we have the opposite problem; imagine if you were patching Makefile. > You mean, for example, the log message: > > * mi/mi-cmd-stack.c (mi_cmd_stack_info_frame): New function. > > * mi/mi-cmds.c (mi_cmds): Replace entry for -stack-info-frame. > Make it use mi_cmd_stack_info_frame > > * mi/mi-cmds.h (mi_cmd_stack_info_frame): New declaration. > > should appear in the individual CVS log for each of the files > mi/mi-cmd-stack.c, mi/mi-cmds.c and mi/mi-cmds.h? I thought that the > ChangeLog was there for that purpose. The idea is to use a single "cvs commit" to check in all the files that you've modified. So, yes, one log message for them all. Take a look at "cvs log" output on a couple files, or the archives at http://sourceware.org/ml/gdb-cvs/. > > 2005-06-20 Nick Roberts > > * gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for > -stack-select-frame without arguments. > (test_stack_frame_listing): Add test for newly implemented command > -stack-info-frame. OK (but be careful of leading tabs in the changelog). -- Daniel Jacobowitz CodeSourcery, LLC