From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8360 invoked by alias); 20 Jun 2005 01:31:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8188 invoked by uid 22791); 20 Jun 2005 01:31:33 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 01:31:33 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DkB8O-00083c-4P for gdb-patches@sources.redhat.com; Sun, 19 Jun 2005 21:31:32 -0400 Date: Mon, 20 Jun 2005 01:31:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-info-frames Message-ID: <20050620013131.GA30942@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <17075.57612.684597.392526@farnswood.snap.net.nz> <20050618155742.GB3663@nevyn.them.org> <17076.42233.730605.834264@farnswood.snap.net.nz> <20050618232032.GA28368@nevyn.them.org> <17076.59646.873454.551250@farnswood.snap.net.nz> <20050619145612.GA8219@nevyn.them.org> <17077.61587.164352.664225@farnswood.snap.net.nz> <20050620000041.GA25632@nevyn.them.org> <17078.6920.672827.180846@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17078.6920.672827.180846@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00305.txt.bz2 On Mon, Jun 20, 2005 at 01:25:28PM +1200, Nick Roberts wrote: > > > > > 1) mi_cmd_stack_info_frame uses print_frame_info instead of > > > > > print_stack_frame. This follows mi_cmd_stack_list_frames and means > > > > > that the argument values aren't printed. > ... > > > > Which change? > > > > #1. Why not print the arguments? I guess your logic is that if you > > want them, you can find them by a round trip through > > -stack-list-frames, is that it? > > Well, through -stack-list-arguments (mi_cmd_stack_list_frames doesn't print > arguments: I've used the same call to print_frame_info in -stack-info-frame). > Also print_stack_frame calls eventually calls print_frame_info after a call to > catch_errors, so it seemed more efficient. OK, makes sense. Thank you. -- Daniel Jacobowitz CodeSourcery, LLC