From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12412 invoked by alias); 20 Jun 2005 00:01:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11638 invoked by uid 22791); 20 Jun 2005 00:00:46 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 00:00:46 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1Dk9iU-0006h3-1G; Sun, 19 Jun 2005 20:00:42 -0400 Date: Mon, 20 Jun 2005 00:01:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-info-frames Message-ID: <20050620000041.GA25632@nevyn.them.org> Mail-Followup-To: Nick Roberts , Eli Zaretskii , gdb-patches@sources.redhat.com References: <17075.30993.384316.356236@farnswood.snap.net.nz> <20050618015756.GA30430@nevyn.them.org> <17075.57612.684597.392526@farnswood.snap.net.nz> <20050618155742.GB3663@nevyn.them.org> <17076.42233.730605.834264@farnswood.snap.net.nz> <20050618232032.GA28368@nevyn.them.org> <17076.59646.873454.551250@farnswood.snap.net.nz> <20050619145612.GA8219@nevyn.them.org> <17077.61587.164352.664225@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17077.61587.164352.664225@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00302.txt.bz2 On Mon, Jun 20, 2005 at 10:24:19AM +1200, Nick Roberts wrote: > I wasn't trying to make up the rules, just interpret them. I posted a very > similar patch earlier which was reviewed. As no branch/release is imminent, > it seemed a safe thing to do. I know not to apply judgement again. Sorry. OK, thanks. > > If you have trouble juggling patches, have a complete checkout for each > > independent project you are working on. That's not hard to do. > > I'll have to work out a new routine. Contributing to Emacs works differently. It's a serious suggestion - I often have a tree for everything I'm working on, and that lets me make sure that I keep things independent. > > > This commit is slightly different in two respects: > > > > > > 1) mi_cmd_stack_info_frame uses print_frame_info instead of > > > print_stack_frame. This follows mi_cmd_stack_list_frames and means > > > that the argument values aren't printed. > > > > > > 2) The documentation for -stack-info-frame previously said (before I > > > removed it) "Get info on the current frame.". I've corrected this to > > > "Get info on the selected frame." I've also removed the argument > > > values from the example as explained in 1). > > > > Despite the fact that you made it up as you went along. Why did you > > decide that this change was a better idea? > > Which change? #1. Why not print the arguments? I guess your logic is that if you want them, you can find them by a round trip through -stack-list-frames, is that it? > The patch was OK but the diff wasn't. I picked up the backup copy by mistake: Great! Thank you. -- Daniel Jacobowitz CodeSourcery, LLC