From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 686 invoked by alias); 17 Jun 2005 14:04:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 675 invoked by uid 22791); 17 Jun 2005 14:04:14 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 17 Jun 2005 14:04:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DjHS6-0006Xx-JS; Fri, 17 Jun 2005 10:04:10 -0400 Date: Fri, 17 Jun 2005 14:04:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Nick Roberts , Bob Rossi , gdb-patches@sources.redhat.com Subject: Re: [PATCH: gdb/mi + doco] -var-update Message-ID: <20050617140410.GA24575@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , Nick Roberts , Bob Rossi , gdb-patches@sources.redhat.com References: <16922.43915.346792.973282@farnswood.snap.net.nz> <01c51898$Blat.v2.4$f6fd05c0@zahav.net.il> <16929.8147.933720.246602@farnswood.snap.net.nz> <16955.41017.161288.832646@farnswood.snap.net.nz> <20050401024942.GA2179@white> <17013.35649.62745.226730@farnswood.snap.net.nz> <20050502040526.GA10023@nevyn.them.org> <17013.54662.20554.239976@farnswood.snap.net.nz> <20050617034329.GH17013@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00257.txt.bz2 On Fri, Jun 17, 2005 at 01:08:58PM +0200, Eli Zaretskii wrote: > > Date: Thu, 16 Jun 2005 23:43:29 -0400 > > From: Daniel Jacobowitz > > Cc: Bob Rossi , gdb-patches@sources.redhat.com > > > > I don't remember the entire outcome of your discussion with Eli > > My opinion (which Nick eventually accepted, IIRC) is here: > > http://sourceware.org/ml/gdb-patches/2005-02/msg00204.html > > > but I find the idea of having --with-values sometimes and > > --all-values other times a bit confusing. I went trying to figure > > out which meant what and that's when I noticed this problem. > > If you have suggestions for better names for these options, please say > what they are. Alternatively, if you are saying that the manual patch > doesn't explain them well enough, please point out the unclear text. The latest manual patch Nick posted was so mangled that I couldn't work out what the new text was. Before the patch -stack-list-locals takes --no-values, --all-values, and --simple-values. -var-list-children takes --no-values and --all-values. After the patch -stack-list-locals takes --no-values, --all-values, and --simple-values. -var-list-children takes --no-values and --with-values. -var-update takes --no-values and --with-values. So, we still have --all-values, we've introduced --with-values, and we've made an incompatible change. I think that, other than the incompatible change, I don't have a big problem with this - they are different commands, they can take different options. But consistency would be nice. I do see that you OK'd the incompatible change: http://sourceware.org/ml/gdb-patches/2005-02/msg00232.html I'm less comfortable with that than you and Nick are; we shipped GDB 6.3 with -var-list-children --all-values, and it's even in the manual. Your original objection was: > Also, I find the choice of "--all-values" unfortunate. The opposite > of "--no-values" is something like "--with-values" or > "--print-values", not "--all-values". Could you elaborate? I think that --all-values is a reasonable option; especially since --simple-values would be a reasonable extension here also. It causes the values for objects other than structs/arrays/unions to be printed. Would you be happier with -var-update --all-values if -var-update --simple-values also worked? -- Daniel Jacobowitz CodeSourcery, LLC