From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19708 invoked by alias); 14 Jun 2005 21:37:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19683 invoked by uid 22791); 14 Jun 2005 21:37:06 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 14 Jun 2005 21:37:06 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j5ELawnW017151; Tue, 14 Jun 2005 23:36:58 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j5ELawxp022196; Tue, 14 Jun 2005 23:36:58 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j5ELav79007815; Tue, 14 Jun 2005 23:36:57 +0200 (CEST) Date: Tue, 14 Jun 2005 21:37:00 -0000 Message-Id: <200506142136.j5ELav79007815@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: mark.kettenis@xs4all.nl, manjo@austin.ibm.com, gdb-patches@sources.redhat.com In-reply-to: <20050613224330.GB13598@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 13 Jun 2005 18:43:30 -0400) Subject: Re: [RFC] GDBserver compiler warnings patch References: <20050613015944.GA9288@nevyn.them.org> <200506132138.j5DLcmgt018463@elgar.sibelius.xs4all.nl> <20050613224330.GB13598@nevyn.them.org> X-SW-Source: 2005-06/txt/msg00188.txt.bz2 Date: Mon, 13 Jun 2005 18:43:30 -0400 From: Daniel Jacobowitz > 2. On OpenBSD (and possibly other BSD-like systems) you'll need to > #include to get socklen_t. > > I propose to replace the above with what I just committed to gdb's > configure.ac: > > AC_CHECK_TYPES(socklen_t, [], [], > [#include > #include > ]) That's fine; could you take care of it? I committed the attached: Index: ChangeLog from Mark Kettenis * configure.ac: Simplify and improve check for socklen_t. * configure, config.in: Regenerate. Index: configure.ac =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v retrieving revision 1.3 diff -u -p -r1.3 configure.ac --- configure.ac 13 Jun 2005 01:59:22 -0000 1.3 +++ configure.ac 14 Jun 2005 21:33:17 -0000 @@ -40,10 +40,10 @@ AC_CHECK_HEADERS(sgtty.h termio.h termio BFD_NEED_DECLARATION(strerror) -AC_CHECK_TYPE(socklen_t, - [AC_DEFINE(HAVE_SOCKLEN_T, 1, [Define if you have socklen_t.])], - [], [#include ]) - +AC_CHECK_TYPES(socklen_t, [], [], +[#include +#include +]) . ${srcdir}/configure.srv if test "${srv_linux_usrregs}" = "yes"; then