From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1001 invoked by alias); 14 Jun 2005 17:48:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 979 invoked by uid 22791); 14 Jun 2005 17:48:19 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 14 Jun 2005 17:48:19 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DiFWK-0004WZ-8c; Tue, 14 Jun 2005 13:48:16 -0400 Date: Tue, 14 Jun 2005 17:48:00 -0000 From: Daniel Jacobowitz To: Eric Christopher Cc: David Ung , binutils@sourceware.org, gdb-patches@sources.redhat.com Subject: Re: [patch] MIPS16e support in simulator. Message-ID: <20050614174816.GA17325@nevyn.them.org> Mail-Followup-To: Eric Christopher , David Ung , binutils@sourceware.org, gdb-patches@sources.redhat.com References: <1118335933.1627.639.camel@localhost.localdomain> <20050613031833.GG9288@nevyn.them.org> <1118682165.5119.0.camel@localhost.localdomain> <20050613170353.GA19310@nevyn.them.org> <1118704956.5119.68.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1118704956.5119.68.camel@localhost.localdomain> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00182.txt.bz2 On Mon, Jun 13, 2005 at 04:22:36PM -0700, Eric Christopher wrote: > On Mon, 2005-06-13 at 13:03 -0400, Daniel Jacobowitz wrote: > > On Mon, Jun 13, 2005 at 10:02:45AM -0700, Eric Christopher wrote: > > > > > > > So um... unfortunately, GDB does not have an active MIPS maintainer at > > > > the moment. I do not see anything (other than your followup about the > > > > mipsisa32 configure stanza) obviously wrong with these changes, but I > > > > can't provide any useful review of the mips-specific bits. I don't > > > > suppose someone on binutils@ could lend a hand? > > > > > > > > > > I will, url to the original patch? > > > > http://sourceware.org/ml/gdb-patches/2005-06/msg00078.html > > http://sourceware.org/ml/gdb-patches/2005-06/msg00079.html > > Looks like the jump instructions aren't executing the instructions in > the delay slot? See the definition of jalr in m16.igen. > > I guess a good question would be asking how this patch was tested? > > Otherwise it looks fine. Given this, and the followups, the patch is OK. It looks like David doesn't have commit access; is that right? Let me know and I'll take care of the patch. -- Daniel Jacobowitz CodeSourcery, LLC