From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39941-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 24817 invoked by alias); 13 Jun 2005 22:43:43 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24744 invoked by uid 22791); 13 Jun 2005 22:43:34 -0000
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 13 Jun 2005 22:43:34 +0000
Received: from drow by nevyn.them.org with local (Exim 4.50)
	id 1DhxeU-0003aS-Np; Mon, 13 Jun 2005 18:43:30 -0400
Date: Mon, 13 Jun 2005 22:43:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: manjo@austin.ibm.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC] GDBserver compiler warnings patch
Message-ID: <20050613224330.GB13598@nevyn.them.org>
Mail-Followup-To: Mark Kettenis <mark.kettenis@xs4all.nl>,
	manjo@austin.ibm.com, gdb-patches@sources.redhat.com
References: <Pine.LNX.4.58.0506011237240.5282@lazy> <20050613015944.GA9288@nevyn.them.org> <200506132138.j5DLcmgt018463@elgar.sibelius.xs4all.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200506132138.j5DLcmgt018463@elgar.sibelius.xs4all.nl>
User-Agent: Mutt/1.5.8i
X-SW-Source: 2005-06/txt/msg00174.txt.bz2

On Mon, Jun 13, 2005 at 11:38:48PM +0200, Mark Kettenis wrote:
>    Date: Sun, 12 Jun 2005 21:59:44 -0400
>    From: Daniel Jacobowitz <drow@false.org>
> 
> Hi Daniel,
> 
> One small and one larger nit about your patch:
> 
>    Index: configure.ac
>    ===================================================================
>    RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v
>    retrieving revision 1.2
>    diff -u -p -r1.2 configure.ac
>    --- configure.ac	24 Feb 2005 20:26:32 -0000	1.2
>    +++ configure.ac	13 Jun 2005 01:57:11 -0000
>    @@ -40,10 +40,16 @@ AC_CHECK_HEADERS(sgtty.h termio.h termio
> 
>     BFD_NEED_DECLARATION(strerror)
> 
>    +AC_CHECK_TYPE(socklen_t,
>    +	      [AC_DEFINE(HAVE_SOCKLEN_T, 1, [Define if you have socklen_t.])],
>    +	      [], [#include <sys/socket.h>])
> 
> 1. That AC_DEFINE is superfluous.  AC_CHECK_TYPE does that for you ;-).

The documentation for autoconf blows, and I get easily tired of reading
obfuscated m4.  Thanks.

> 2. On OpenBSD (and possibly other BSD-like systems) you'll need to
>    #include <sys/types.h> to get socklen_t.
> 
> I propose to replace the above with what I just committed to gdb's
> configure.ac:
> 
> AC_CHECK_TYPES(socklen_t, [], [],
> [#include <sys/types.h>
> #include <sys/socket.h>
> ])

That's fine; could you take care of it?

-- 
Daniel Jacobowitz
CodeSourcery, LLC