From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31566 invoked by alias); 13 Jun 2005 13:48:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31486 invoked by uid 22791); 13 Jun 2005 13:48:01 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 13 Jun 2005 13:48:01 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DhpIF-0001s8-7a; Mon, 13 Jun 2005 09:47:59 -0400 Date: Mon, 13 Jun 2005 13:48:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -data-list-changed-registers (Take 2) Message-ID: <20050613134759.GA7102@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17053.38913.487990.775198@farnswood.snap.net.nz> <20050603191326.GA538@nevyn.them.org> <17056.56149.181259.513462@farnswood.snap.net.nz> <20050603223652.GA8203@nevyn.them.org> <17057.37727.725621.254956@farnswood.snap.net.nz> <17060.46539.131335.71422@farnswood.snap.net.nz> <17066.35303.833870.612064@farnswood.snap.net.nz> <20050613024022.GB9288@nevyn.them.org> <17069.4116.293354.462840@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17069.4116.293354.462840@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00153.txt.bz2 On Mon, Jun 13, 2005 at 04:48:20PM +1200, Nick Roberts wrote: > > It looks like you're doing basically mi_out_rewind. There's already > > several of these in captured_mi_execute_command. They don't catch this > > because throw_exception takes us past them, all the way back to > > mi_execute_command. > > > > If we add an mi_out_rewind call right here: > > 1176 /* The command execution failed and error() was called > > 1177 somewhere */ > > > > Then the problem goes away. > > So, basically, it just needed one line fix! Hmm...I think I'll look at the > rest of the MI code before I start re-inventing it again. > > From mi_cmd_data_list_register_values, I removed: > > if (!target_has_registers) > { > mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers."); > return MI_CMD_ERROR; > } > > Why do you think it should stay? Cuz it was late and I wasn't paying a great deal of attention to your patch, once I figured out the mi_out_rewind problem. In the interest of uniformity, let's remove it. Could you (test and) commit the obvious patch? -- Daniel Jacobowitz CodeSourcery, LLC