Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Manoj Iyer <manjo@austin.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Print thread id in hex.
Date: Mon, 13 Jun 2005 03:29:00 -0000	[thread overview]
Message-ID: <20050613032917.GK9288@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0506071258360.13058@lazy>

On Tue, Jun 07, 2005 at 01:10:36PM -0500, Manoj Iyer wrote:
> 
> From the earlier discussion sub: "debugging threaded apps. thread ID
> missing in corefile." I wrote this patch to print the thread ids in HEX
> (%#lx)  instead of decimal (%ld).

This is OK, with two trivial changes: please use 0x%lx instead of %#lx,
and please cast to unsigned long instead of long.  Neither of these
makes a real difference, but they're both a little clearer.  Thanks!

> 2005-06-07  Manoj Iyer  <manjo@austin.ibm.com>
> 
> 	* linux-thread-db.c (thread_db_pid_to_str): Print thread id in hex.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


      reply	other threads:[~2005-06-13  3:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-07 18:19 Manoj Iyer
2005-06-13  3:29 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050613032917.GK9288@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=manjo@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox