From: Daniel Jacobowitz <drow@false.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC] Add a little IBM XL C++ specific code in dwarf2read.c, to set TYPE_VPTR_FIELDNO and TYPE_VPTR_BASETYPE of a virtual class correctly
Date: Mon, 13 Jun 2005 03:26:00 -0000 [thread overview]
Message-ID: <20050613032601.GJ9288@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0505311108170.9549@plinuxt18.cn.ibm.com>
On Tue, May 31, 2005 at 11:26:52AM +0800, Wu Zhou wrote:
> On Mon, 30 May 2005, Daniel Jacobowitz wrote:
> > I think the change is probably reasonable. Alternatively, we could
> > teach GDB not to rely on TYPE_VPTR_FIELDNO and TYPE_VPTR_BASETYPE if
> > the C++ ABI in use does not require them, which the GNU v3 ABI does
> > not. That would also be a good solution.
>
> Yes. I had ever thought of that and even added a file named xlc-abi.c
> to not rely on these two fields. But I am not sure whether this is the
> most appropriate way. The developer of XL compiler ever told me that
> they also comply to the GNU C++ ABI. Maybe it is acceptable to code
> that change in gnu-v3-abi.c. My question is: which one is better and
> more prone to be accepted by mainline? Any comments, suggestion and
> idea are highly appreciated!
Right - I did not mean adding a new file for xlc (which you should not
need to do), but modifying the GNU v3 support and common code instead.
I think that fixing this would be more work, but also more correct.
I haven't really looked yet at how much work it would be.
--
Daniel Jacobowitz
CodeSourcery, LLC
prev parent reply other threads:[~2005-06-13 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 3:31 Wu Zhou
2005-05-31 5:46 ` Daniel Jacobowitz
2005-05-31 13:27 ` Wu Zhou
2005-06-13 3:26 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050613032601.GJ9288@nevyn.them.org \
--to=drow@false.org \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=woodzltc@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox