From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5336 invoked by alias); 10 Jun 2005 22:12:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5324 invoked by uid 22791); 10 Jun 2005 22:12:44 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 10 Jun 2005 22:12:44 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j5AMCO8r022545; Sat, 11 Jun 2005 00:12:24 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j5AMCOId017160; Sat, 11 Jun 2005 00:12:24 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j5AMCOoq028820; Sat, 11 Jun 2005 00:12:24 +0200 (CEST) Date: Fri, 10 Jun 2005 22:12:00 -0000 Message-Id: <200506102212.j5AMCOoq028820@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com, drow@false.org In-reply-to: <428CCBB8.4050603@gnu.org> (message from Andrew Cagney on Thu, 19 May 2005 13:24:08 -0400) Subject: Re: [commit] gdb_byte regcache.[hc] References: <428CC0B1.6020008@gnu.org> <20050519170724.GA24675@nevyn.them.org> <428CCBB8.4050603@gnu.org> X-SW-Source: 2005-06/txt/msg00101.txt.bz2 Date: Thu, 19 May 2005 13:24:08 -0400 From: Andrew Cagney 2005-05-19 Andrew Cagney * regcache.h (regcache_raw_read, regcache_raw_write) (regcache_raw_read_part, regcache_raw_write_part) (regcache_cooked_read_part, regcache_cooked_write_part) (regcache_cooked_read, regcache_cooked_write) (regcache_raw_supply, regcache_raw_collect) (regcache_cooked_read_ftype, regcache_save, regcache_restore) (deprecated_read_register_gen, deprecated_write_register_gen) (deprecated_read_register_bytes, deprecated_write_register_bytes) (deprecated_grub_regcache_for_registers): Use gdb_byte for byte buffer parameters. * ia64-tdep.c (ia64_extract_return_value): Update. * frame.c (do_frame_register_read): Update. * regcache.c (deprecated_grub_regcache_for_registers) (struct regcache, regcache_save, regcache_restore, regcache_cpy) (do_cooked_read, regcache_xmalloc, register_buffer) (deprecated_read_register_bytes, regcache_raw_read) (regcache_raw_read_signed, regcache_raw_read_unsigned) (deprecated_read_register_gen, regcache_cooked_read) (regcache_cooked_read_signed, regcache_cooked_read_unsigned) (deprecated_write_register_gen, regcache_cooked_write) (deprecated_write_register_bytes, regcache_raw_read_part) (regcache_raw_write_part, regcache_cooked_read_part) (regcache_cooked_write_part, read_register, regcache_raw_supply): I know it's a bit late (just returned from vacation in .ca ;-), but there is a nasty problem with the register cache stuff in this patch :-(. Many bits of native code pass native data types to regcache_raw_write, and this now raises a compiler warning. I'm not sure how to solve this; adding casts all over the code is really, really ugly, and I really, really don't want to do that. The best thing I can come up with is that we revert the regcache_raw_xxx interfaces back to using `void *', whereas we keep the regcache_cooked_xxx interface as they are now (using `gdb_byte *'). Mark