From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18231 invoked by alias); 9 Jun 2005 13:20:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18202 invoked by uid 22791); 9 Jun 2005 13:20:05 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 09 Jun 2005 13:20:05 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DgMx0-0000JL-VL; Thu, 09 Jun 2005 09:20:03 -0400 Date: Thu, 09 Jun 2005 13:20:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Patch to fix the SEGV error when printing f77 array element Message-ID: <20050609132002.GB965@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00077.txt.bz2 On Thu, Jun 09, 2005 at 06:02:03PM +0800, Wu Zhou wrote: > Daniel, > > I had cleaned up the patch to fix the SEGV error we discussed on gdb@ the > days before and tested it on ppc64 arch with the latest CVS tree. It > works ok. Please review and comment. Thanks. Can you handle TYPE_CODE_PTR before the switch statement, instead? Also, rather than default, you can probably check that the target type of the pointer is TYPE_CODE_FUNC. Do you feel up to adding our first compilable fortran test to the testsuite? -- Daniel Jacobowitz CodeSourcery, LLC