From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12980 invoked by alias); 7 Jun 2005 00:07:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12709 invoked by uid 22791); 7 Jun 2005 00:07:29 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 07 Jun 2005 00:07:29 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DfRcr-0003Qh-4D; Mon, 06 Jun 2005 20:07:25 -0400 Date: Tue, 07 Jun 2005 00:07:00 -0000 From: Daniel Jacobowitz To: Manoj Iyer Cc: Kevin Buettner , gdb-patches@sources.redhat.com Subject: Re: [PATCH] solib-svr4.c gdb_byteised. Message-ID: <20050607000725.GA13127@nevyn.them.org> Mail-Followup-To: Manoj Iyer , Kevin Buettner , gdb-patches@sources.redhat.com References: <20050603141436.1b8d24aa@ironwood.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00050.txt.bz2 On Mon, Jun 06, 2005 at 05:17:08PM -0500, Manoj Iyer wrote: > > Just commited the following patch. > > 2005-06-06 Manoj Iyer > > * solib-svr4.c: Change type of 'lm' to gdb_byte. > (elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte. > (first_link_map_member): Converted type of r_map_buf to gdb_byte. > (open_symbol_file_object): Converted type of l_name_buf to gdb_byte. > (svr4_fetch_objfile_link_map): Converted type of l_name_buf to > gdb_byte. FYI, please use the changelog entry as the CVS commit message in the future. Also: > > This patch is okay with me. Just fix the first line of your ChangeLog > > entry as follows: > > > > * solib-svr4.c: (struct lm_info): Change type of ``lm'' to gdb_byte. Both the version you used and Kevin's are wrong, Kevin picked up an extra colon: * solib-svr4.c (struct lm_info): Change type of ``lm'' to gdb_byte. -- Daniel Jacobowitz CodeSourcery, LLC