From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11599 invoked by alias); 3 Jun 2005 22:36:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11591 invoked by uid 22791); 3 Jun 2005 22:36:55 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 03 Jun 2005 22:36:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DeKmb-00029C-PW; Fri, 03 Jun 2005 18:36:53 -0400 Date: Fri, 03 Jun 2005 22:36:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -data-list-changed-registers Message-ID: <20050603223652.GA8203@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17053.38913.487990.775198@farnswood.snap.net.nz> <20050603191326.GA538@nevyn.them.org> <17056.56149.181259.513462@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17056.56149.181259.513462@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00036.txt.bz2 On Sat, Jun 04, 2005 at 10:36:05AM +1200, Nick Roberts wrote: > Daniel Jacobowitz writes: > > On Wed, Jun 01, 2005 at 11:12:01PM +1200, Nick Roberts wrote: > > > > > > Currently the GDB/MI command -data-list-changed-registers gives an internal > > > error if there is no stack i.e when there is no inferior process: > > > > This has come up before; the right solution is elsewhere. I believe > > that updating register_changed_p and get_register to use > > get_selected_frame() will work. > > > > I have a big patch for this sort of thing lying around, but the problem > > is that many of the references to deprecated_selected_frame should > > really by fixed by adding a frame parameter to the function, so that > > they can be used on non-selected frames. They need to be looked over > > one by one and I haven't gotten round to it yet. > > Could this patch be applied as an interim measure? Currently any front end > that uses -data-list-changed-registers without a stack crashes. I would prefer not to; right now the presence of deprecated_selected_frame is a good warning sign. I can find you a copy if you want to look at individual places that should be investigated. I think the changes are right in this case, though. Could you take a look at those two functions (the change to make is obvious) and see if that fixes your problem? -- Daniel Jacobowitz CodeSourcery, LLC