From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14721 invoked by alias); 1 Jun 2005 00:14:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14668 invoked by uid 22791); 1 Jun 2005 00:14:46 -0000 Received: from lakermmtao10.cox.net (HELO lakermmtao10.cox.net) (68.230.240.29) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 01 Jun 2005 00:14:46 +0000 Received: from white ([68.9.64.121]) by lakermmtao10.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050601001439.OAXG7787.lakermmtao10.cox.net@white>; Tue, 31 May 2005 20:14:39 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1DdGsa-00044z-00; Tue, 31 May 2005 20:14:40 -0400 Date: Wed, 01 Jun 2005 00:14:00 -0000 From: Bob Rossi To: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: mi tty commands Message-ID: <20050601001440.GB15414@white> Mail-Followup-To: Eli Zaretskii , gdb-patches@sources.redhat.com References: <01c51b79$Blat.v2.4$4089e9a0@zahav.net.il> <20050225211911.GA21363@white> <20050225212201.GA3592@nevyn.them.org> <20050228162003.GA27783@white> <20050302025219.GA29948@white> <20050311022644.GA15563@white> <20050522210040.GB9231@white> <20050528230855.GE22435@nevyn.them.org> <20050529205435.GA11243@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050529205435.GA11243@white> User-Agent: Mutt/1.3.28i X-SW-Source: 2005-06/txt/msg00000.txt.bz2 On Sun, May 29, 2005 at 04:54:35PM -0400, Bob Rossi wrote: > On Sun, May 29, 2005 at 09:55:23AM +0300, Eli Zaretskii wrote: > > > Date: Sat, 28 May 2005 19:08:55 -0400 > > > From: Daniel Jacobowitz > > > > > > On Sun, May 22, 2005 at 05:00:40PM -0400, Bob Rossi wrote: > > > > On Thu, Mar 10, 2005 at 09:26:44PM -0500, Bob Rossi wrote: > > > > > Ping > > > > > > > > Ping, and O yeah, I updated the patch the best I could to get the code > > > > to conform with the GNU coding standards. I hope I'm getting this right. > > > > > > Not quite, but I don't mind proofreading :-) > > > > Sorry, I somehow managed to miss the original message. My comments > > are below. > > > > > + /* add the filename of the terminal connected to inferior I/O */ > > > + add_setshow_string_noescape_cmd ( "inferior_tty", class_run, > > > + &inferior_io_terminal, _("\ > > > +Set terminal for future runs of program being debugged."), _("\ > > > +Show terminal for future runs of program being debugged."), _("\ > > > +Usage: set inferior_tty /dev/pts/1"), NULL, NULL, &setlist, &showlist); > > > + set_cmd_completer (c, filename_completer); > > > > You are adding a new user command, but you didn't add its > > documentation to gdb.texinfo. Please add that; I don't want us to > > ever have undocumented commands again. > > > > And I agree with Daniel: let's get rid of that underscore in the > > command's name. > > Oops, I don't know how I missed that. I added the doco for the MI > commands and this must have slipped passed me. > > I'm having trouble finding a particular spot in the manual for this > command. Do you have any suggestions? Eli, is the MI doco good enough? or do you want the doco for set/show? If you want the set/show doco, please let me know where to put it in the manual. Thanks very much, Bob Rossi