From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28161 invoked by alias); 30 May 2005 15:48:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15735 invoked by uid 22791); 30 May 2005 15:33:43 -0000 Received: from cpe-144-131-104-16.nsw.bigpond.net.au (HELO takamaka.act-europe.fr) (144.131.104.16) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 30 May 2005 15:33:42 +0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 27B4A47958; Mon, 30 May 2005 15:45:38 +1000 (EST) Date: Mon, 30 May 2005 15:59:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Set current language when dumping symtab Message-ID: <20050530054538.GM18754@adacore.com> References: <20050504001955.GE2439@adacore.com> <20050528234905.GF22435@nevyn.them.org> <20050529021056.GF18754@adacore.com> <20050529025401.GA14380@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050529025401.GA14380@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-05/txt/msg00633.txt.bz2 > > #define TRY_CATCH(EXCEPTION,MASK) \ > > { \ > > EXCEPTIONS_SIGJMP_BUF *buf = \ > > exceptions_state_mc_init (uiout, &(EXCEPTION), (MASK)); \ > > EXCEPTIONS_SIGSETJMP (*buf); \ > > } \ > > while (exceptions_state_mc_action_iter ()) \ > > while (exceptions_state_mc_action_iter_1 ()) > > > > There is a dependency on "uiout". Perhaps it would be better to include > > that file from exceptions.h, rather than requiring all clients to include > > it themselves? I could send a separate RFA for that. > > Yes please. I figured it was something like that, went looking at the > definition, and my eyes skipped right over it. Sure. Patch sent, although I can provide the URL yet, as sources.redhat.com is unfortunately refusing connections on port 25. Will send the URL as a followup message as soon as the problem is fixed. > > > Also, I am not convinced that the new TRY_CATCH is necessary. The > > > only bit likely to throw is print_symbol, which is already wrapped in > > > catch_errors. > > > > That's true, and I'd be happy to remove it. But I thought that it might > > be safer to use it anyway, so that any change underneath that might cause > > an exception to be thrown does not affect this code. This is a hard > > guaranty that the language will never be changed as a side-effect of > > this command. Okidoke, understood. New patch attached. 2005-05-30 Joel Brobecker * symmisc.c (dump_symtab_1): Renamed from dump_symtab. (dump_symtab): New function. Tested on x86-linux. Thanks, -- Joel